Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.pytorch-bin: 1.7.0 -> 1.7.1 #106585

Merged
merged 1 commit into from Dec 16, 2020
Merged

python3Packages.pytorch-bin: 1.7.0 -> 1.7.1 #106585

merged 1 commit into from Dec 16, 2020

Conversation

danieldk
Copy link
Contributor

Motivation for this change

This also adds Python 3.9 compatibility.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

jonringer
jonringer reviewed Dec 11, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the commit should be

python3Packages.pytorch-bin: 1.7.0 -> 1.7.1

(the -bin is missing)

@danieldk
python3Packages.pytorch-bin: 1.7.0 -> 1.7.1
b51d8fc 
This also adds Python 3.9 compatibility.
@danieldk
Copy link
Contributor Author

the commit should be

python3Packages.pytorch-bin: 1.7.0 -> 1.7.1

(the -bin is missing)

Thanks! I first wanted to do both the regular and -bin variants in one PR, but then decided to do two PRs, but forgot to give this one the appropriate message.

@danieldk danieldk changed the title python3Packages.pytorch: 1.7.0 -> 1.7.1 python3Packages.pytorch-bin: 1.7.0 -> 1.7.1 Dec 11, 2020
@danieldk danieldk merged commit e6c42f6 into NixOS:master Dec 16, 2020
@danieldk danieldk deleted the pytorch-bin-1.7.1 branch December 16, 2020 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prusnak prusnak prusnak approved these changes

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@danieldk @prusnak @jonringer