Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wallabag: 2.3.8 -> 2.4.0 #106597

Merged
merged 1 commit into from Jan 18, 2021
Merged

wallabag: 2.3.8 -> 2.4.0 #106597

merged 1 commit into from Jan 18, 2021

Conversation

mweinelt
Copy link
Member

@mweinelt mweinelt commented Dec 10, 2020 •
edited

Motivation for this change

https://github.com/wallabag/wallabag/releases/tag/2.4.0

TODO: Test this in prod. WFM.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@mweinelt
Copy link
Member Author

Tested and running in production.

Remember to read the release notes and run

php ${package}/bin/console wallabag:generate-hashed-urls --no-interaction --env=prod

after you're done.

@mweinelt mweinelt merged commit 6867c3b into NixOS:master Jan 18, 2021
@mweinelt mweinelt deleted the wallabag branch January 18, 2021 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 left review comments

@schneefux schneefux Awaiting requested review from schneefux

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mweinelt @SuperSandro2000