Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

ocamlPackages.base: 0.13.1 -> 0.13.2 #106613

Closed
wants to merge 1 commit into from
Closed

Conversation

bcc32
Copy link
Contributor

@bcc32 bcc32 commented Dec 10, 2020

Motivation for this change

Update base to the latest version, 0.13.2.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

I noticed, when running nixpkgs-review rev HEAD, that irmin-http, irmin-unix, and torch failed to build. torch doesn't build for me in master anyway. irmin-http and irmin-unix build fine for me if I just run nix build -f . at the tip of this PR. 馃し

@vbgl
Copy link
Contributor

vbgl commented Dec 11, 2020

The base library at version 0.13 is going to be removed in #106386. Also, that PR has a fix for torch.

@bcc32
Copy link
Contributor Author

bcc32 commented Dec 11, 2020

Ah, I wrote this PR before #106386 and when I searched for the PR upgrading janestreet to 0.14 I didn't find it then! Happy to close this now.

@bcc32 bcc32 closed this Dec 11, 2020
@bcc32 bcc32 deleted the base-update-0.13 branch December 11, 2020 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants