Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libvirt: add support for usb redirection #106595

Closed
wants to merge 1 commit into from
Closed

libvirt: add support for usb redirection #106595

wants to merge 1 commit into from

Conversation

symphorien
Copy link
Member

spice-client-glib-usb-acl-helper requires a setcap wrapper

Fixes #106594

Tested on 20.09

Alternatives
  • patch spice-gtk to point to /run/wrappers instead of using the environment variable (I don't know meson good enough to do it properly, unfortunately)
  • make a standalone module programs.spice.whatever.enable to create the wrapper, and have the libvirt module use it
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@symphorien
libvirt: add support for usb redirection
76d18cd 
spice-client-glib-usb-acl-helper requires a setcap wrapper
@symphorien symphorien mentioned this pull request Dec 10, 2020
Closed
@Ma27
Copy link
Member

Ma27 commented Dec 11, 2020

Is there any reason for this change when there's virtualisation.spiceUSBRedirection already?

@symphorien
Copy link
Member Author

Oh indeed I had not seen this option (it's not in 20.09...). I checked and this works.
What about adding virtualisation.spiceUSBRedirection.enable = mkDefault true in the libvirtd module ? The functionnality is exposed in vm-manager so I'd expect it to work out of the box...

@symphorien symphorien closed this Dec 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

libvirt fails when redirecting a usb device to the vm
2 participants
@symphorien @Ma27