Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.psautohint: fix test failures due to pytest 6 #106609

Closed
wants to merge 1 commit into from
Closed

pythonPackages.psautohint: fix test failures due to pytest 6 #106609

wants to merge 1 commit into from

Conversation

sternenseemann
Copy link
Member

Motivation for this change

Fix #106558. Alternative solution to #106464.

The issue with the psautohint test suite was the update to pytest 6.

The proposed solution is to default to pytest 5 and to disable the offending
test if the package is overriden to use pytest 6.

See https://github.com/adobe-type-tools/psautohint/issues/284#issuecomment-742800965
for the explanation and upstream issue.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@sternenseemann
pythonPackages.psautohint: fix test failures due to pytest 6
fd6784a 
test_hashmap_old_version would fail occasionally since pytest 6, so we
disable the test if the package is overriden to use pytest 6 and default
to pytest 5 for the tests.

See: https://github.com/adobe-type-tools/psautohint/issues/284#issuecomment-742800965
@sternenseemann
Copy link
Member Author

@GrahamcOfBorg build python3Packages.psautohint

@sternenseemann sternenseemann mentioned this pull request Dec 10, 2020
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

psautohints: Test broken on python38, aarch64
1 participant
@sternenseemann