Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

monero-gui: 0.17.1.5 -> 0.17.1.6 #106596

Merged
merged 1 commit into from Dec 11, 2020
Merged

monero-gui: 0.17.1.5 -> 0.17.1.6 #106596

merged 1 commit into from Dec 11, 2020

Conversation

r-ryantm
Copy link
Contributor

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/monero-project/monero-gui/releases.

meta.description for monero-gui is: "Private, secure, untraceable currency"

meta.homepage for monero-gui is: "https://getmonero.org/"

meta.changelog for monero-gui is: ""

Updates performed
  • Version update
To inspect upstream changes
Impact
Checks done (click to expand)
Rebuild report (if merged into master) (click to expand) 
4 total rebuild path(s)

1 package rebuild(s)

1 x86_64-linux rebuild(s)
1 i686-linux rebuild(s)
1 x86_64-darwin rebuild(s)
1 aarch64-linux rebuild(s)


First fifty rebuilds by attrpath
monero-gui
Instructions to test this update (click to expand)

Either download from Cachix:

nix-store -r /nix/store/i74vsaqfhldnf0bqhfgj6f49vr41vppm-monero-gui-0.17.1.6 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.

Or, build yourself:

nix-build -A monero-gui https://github.com/r-ryantm/nixpkgs/archive/eb851979623c2353a942532c1b402b7c77223457.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:

ls -la /nix/store/i74vsaqfhldnf0bqhfgj6f49vr41vppm-monero-gui-0.17.1.6
ls -la /nix/store/i74vsaqfhldnf0bqhfgj6f49vr41vppm-monero-gui-0.17.1.6/bin

Pre-merge build results

We have automatically built all packages that will get rebuilt due to
this change.

This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.

Result of nixpkgs-review 1

1 package built:
  • monero-gui
Maintainer pings

cc @rnhmjoj for testing.

@ofborg ofborg bot requested a review from rnhmjoj December 10, 2020 20:50
rnhmjoj
rnhmjoj approved these changes Dec 10, 2020
View reviewed changes
Copy link
Contributor

@rnhmjoj rnhmjoj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I'll wait a bit for others to review before merging.

@RaghavSood
Copy link
Member

Result of nixpkgs-review pr 106596 run on x86_64-linux 1

1 package built:
  • monero-gui

@RaghavSood RaghavSood merged commit 10fafe2 into NixOS:master Dec 11, 2020
@chpio
Copy link

chpio commented Dec 11, 2020 •
edited

wouldn't it make sense to also update the actual "monero" (daemon)?

is there a monero flake?

@rnhmjoj
Copy link
Contributor

rnhmjoj commented Dec 11, 2020

Yes, I don't know why @r-ryantm didn't update it.

@ryantm
Copy link
Member

ryantm commented Dec 11, 2020 

2020-12-10T20:30:05 monero 0.17.1.5 -> 0.17.1.6 https://github.com/monero-project/monero/releases
2020-12-10T20:30:15 FAIL Received ExitFailure 1 when running
Raw command: /nix/store/7rvp30nz4wissy497kyzjks04vgnlcrv-nix-2.3.7/bin/nix eval -f . pkgs.monero.src.urls
Standard error:

error: attribute 'urls' in selection path 'pkgs.monero.src.urls' not found
Received ExitFailure 1 when running
Raw command: /nix/store/7rvp30nz4wissy497kyzjks04vgnlcrv-nix-2.3.7/bin/nix eval -f . pkgs.monero.urls
Standard error:

error: attribute 'urls' in selection path 'pkgs.monero.urls' not found

from https://r.ryantm.com/log/2020-12-10.log

@ryantm
Copy link
Member

ryantm commented Dec 11, 2020

Looks like it is related to it calling "fetchSubmodules"

@ryantm
Copy link
Member

ryantm commented Dec 11, 2020 •
edited

I made an issue with nixpkgs-update to track fixing this problem nix-community/nixpkgs-update#248

@rnhmjoj
Copy link
Contributor

rnhmjoj commented Dec 12, 2020

monero PR: #106725

@r-ryantm r-ryantm deleted the auto-update/monero-gui branch December 12, 2020 14:55
@ryantm
Copy link
Member

ryantm commented Dec 12, 2020

nix-community/nixpkgs-update#248 has been fixed, so monero should at least get past that issue blocking it from auto-updating.

@rnhmjoj
Copy link
Contributor

rnhmjoj commented Dec 12, 2020

Nice, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rnhmjoj rnhmjoj rnhmjoj approved these changes

@mmahut mmahut Awaiting requested review from mmahut mmahut is a code owner

@RaghavSood RaghavSood Awaiting requested review from RaghavSood RaghavSood is a code owner

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@r-ryantm @RaghavSood @chpio @rnhmjoj @ryantm