Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

poetry2nix: 1.13.0 -> 1.14.0 #105477

Merged
merged 2 commits into from Dec 1, 2020
Merged

poetry2nix: 1.13.0 -> 1.14.0 #105477

merged 2 commits into from Dec 1, 2020

Conversation

adisbladis
Copy link
Member

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from jbaum98 November 30, 2020 19:19
SuperSandro2000
SuperSandro2000 reviewed Nov 30, 2020
View reviewed changes
pkgs/development/tools/poetry2nix/poetry2nix/pkgs/poetry/src.json Outdated
"fetchSubmodules": true
}
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing new line.

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 105477 run on x86_64-linux 1

2 packages built:
  • pinnwand
  • poetry

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 105477 run on x86_64-darwin 1

1 package failed to build:
  • pinnwand
1 package built:
  • poetry

pinndwan: basically all tests fail on darwin:

FAILED test/test_http_website.py::WebsiteTestCase::test_website_create_post_many_too_large
FAILED test/test_http_website.py::WebsiteTestCase::test_website_create_post_mismatched
FAILED test/test_http_website.py::WebsiteTestCase::test_website_create_post_multiple
FAILED test/test_http_website.py::WebsiteTestCase::test_website_create_post_nonexistent_expiry
FAILED test/test_http_website.py::WebsiteTestCase::test_website_create_post_nonexistent_lexer
FAILED test/test_http_website.py::WebsiteTestCase::test_website_create_post_nothing
FAILED test/test_http_website.py::WebsiteTestCase::test_website_create_post_only_filenames
FAILED test/test_http_website.py::WebsiteTestCase::test_website_create_post_only_lexers
FAILED test/test_http_website.py::WebsiteTestCase::test_website_create_post_only_raws
FAILED test/test_http_website.py::WebsiteTestCase::test_website_create_post_only_xsrf
FAILED test/test_http_website.py::WebsiteTestCase::test_website_create_post_raw_only_space
FAILED test/test_http_website.py::WebsiteTestCase::test_website_create_post_single
FAILED test/test_http_website.py::WebsiteTestCase::test_website_create_post_too_large
FAILED test/test_http_website.py::WebsiteTestCase::test_website_expiry - Perm...
FAILED test/test_http_website.py::WebsiteTestCase::test_website_hex_nonexistent_paste
FAILED test/test_http_website.py::WebsiteTestCase::test_website_index - Permi...
FAILED test/test_http_website.py::WebsiteTestCase::test_website_index_with_lexer
FAILED test/test_http_website.py::WebsiteTestCase::test_website_index_with_nonexistent_lexer
FAILED test/test_http_website.py::WebsiteTestCase::test_website_nonexistent_page
FAILED test/test_http_website.py::WebsiteTestCase::test_website_raw_nonexistent_paste
FAILED test/test_http_website.py::WebsiteTestCase::test_website_removal - Per...
FAILED test/test_http_website.py::WebsiteTestCase::test_website_show_nonexistent_paste
FAILED test/test_http_website.py::DeprecatedWebsiteTestCase::test_website_download
FAILED test/test_http_website.py::DeprecatedWebsiteTestCase::test_website_download_nonexistent_paste
FAILED test/test_http_website.py::DeprecatedWebsiteTestCase::test_website_hex
FAILED test/test_http_website.py::DeprecatedWebsiteTestCase::test_website_hex_nonexistent_paste
FAILED test/test_http_website.py::DeprecatedWebsiteTestCase::test_website_index_post
FAILED test/test_http_website.py::DeprecatedWebsiteTestCase::test_website_index_post_empty_code
FAILED test/test_http_website.py::DeprecatedWebsiteTestCase::test_website_index_post_no_code
FAILED test/test_http_website.py::DeprecatedWebsiteTestCase::test_website_index_post_no_expiry
FAILED test/test_http_website.py::DeprecatedWebsiteTestCase::test_website_index_post_no_lexer
FAILED test/test_http_website.py::DeprecatedWebsiteTestCase::test_website_index_post_nonexistent_expiry
FAILED test/test_http_website.py::DeprecatedWebsiteTestCase::test_website_index_post_nonexistent_lexer
FAILED test/test_http_website.py::DeprecatedWebsiteTestCase::test_website_logo
FAILED test/test_http_website.py::DeprecatedWebsiteTestCase::test_website_raw
FAILED test/test_http_website.py::DeprecatedWebsiteTestCase::test_website_remove
FAILED test/test_http_website.py::DeprecatedWebsiteTestCase::test_website_remove_nonexistent_paste
FAILED test/test_http_website.py::DeprecatedWebsiteTestCase::test_website_repaste
FAILED test/test_http_website.py::DeprecatedWebsiteTestCase::test_website_repaste_nonexistent_paste
FAILED test/test_http_website.py::DeprecatedWebsiteTestCase::test_website_show
FAILED test/test_utility.py::test_guess_language - OSError: [Errno 24] Too ma...
======================== 88 failed, 11 passed in 8.23s =========================

@adisbladis
pinnwand: Use poetry from pythonPackages
7b3f9e9 
Ideally this software should be repackaged using Poetry2nix rather
that using pythonPackages.

As it is now things are packaged incorrectly.

cc @mweinelt
@ofborg ofborg bot requested a review from mweinelt December 1, 2020 13:39
@adisbladis adisbladis merged commit 25b43c2 into NixOS:master Dec 1, 2020
@mweinelt
Copy link
Member

mweinelt commented Dec 1, 2020

Thanks for fixing that up. I'll look into poetry2nix soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 left review comments

@jbaum98 jbaum98 Awaiting requested review from jbaum98

@mweinelt mweinelt Awaiting requested review from mweinelt

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@adisbladis @SuperSandro2000 @mweinelt