Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update etesync-dav to 0.30.6 and add etebase to python-modules #105496

Closed
wants to merge 10 commits into from
Closed

Update etesync-dav to 0.30.6 and add etebase to python-modules #105496

wants to merge 10 commits into from

Conversation

3699n
Copy link

@3699n 3699n commented Nov 30, 2020 •
edited

Motivation for this change

etesync-dav was stuck on version 0.20.0 and couldn't be updated do to the missing etebase python library.

Things done

This pull request includes a nix expression to build the etebase python library and hence also an update of etesync-dav to version 0.30.6

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • [] Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • [] Ensured that relevant documentation is up to date
  • [] Fits CONTRIBUTING.md.

@3699n
Copy link
Author

3699n commented Nov 30, 2020 •
edited

I made several critical mistakes. Will close this pull request.

@ofborg ofborg bot requested a review from Valodim November 30, 2020 23:45
@3699n 3699n closed this Nov 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

@Valodim Valodim Awaiting requested review from Valodim

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@3699n @Janik-Haag