Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ell, iwd: update #105499

Merged
merged 2 commits into from Dec 1, 2020
Merged

ell, iwd: update #105499

merged 2 commits into from Dec 1, 2020

Conversation

ghost
Copy link

@ghost ghost commented Nov 30, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@jtojnar
Copy link
Contributor

jtojnar commented Nov 30, 2020

Changes:

@jtojnar jtojnar added the 8.has: upstream changes reviewed Reviewer checked the changelogs/commit logs associated with the release and did not find any issues. label Nov 30, 2020
@ofborg ofborg bot requested review from dtzWill, Mic92 and fpletz November 30, 2020 21:57
@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 105499 run on x86_64-linux 1

4 packages built:
  • ell
  • iwd
  • modem-manager-gui
  • ofono

@SuperSandro2000 SuperSandro2000 merged commit 9b7e538 into NixOS:master Dec 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dtzWill dtzWill Awaiting requested review from dtzWill

@Mic92 Mic92 Awaiting requested review from Mic92

@fpletz fpletz Awaiting requested review from fpletz

Assignees
No one assigned
Labels
8.has: upstream changes reviewed Reviewer checked the changelogs/commit logs associated with the release and did not find any issues. 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jtojnar @SuperSandro2000