Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3Packages.pyserial: 3.4 -> 3.5 #105483

Merged
merged 1 commit into from Nov 30, 2020

Conversation

siriobalmelli
Copy link
Contributor

Signed-off-by: Sirio Balmelli sirio@b-ad.ch

Motivation for this change

Update existing package

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Signed-off-by: Sirio Balmelli <sirio@b-ad.ch>
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

failures are broken on target branch

https://github.com/NixOS/nixpkgs/pull/105483
15 packages failed to build:
python37Packages.alarmdecoder python37Packages.pyftdi python37Packages.zigpy-znp python38Packages.alarmdecoder python38Packages.pyftdi python38Packages.zigpy-znp python39Packages.alarmdecoder python39Packages.bellows python39Packages.pyftdi python39Packages.solo-python python39Packages.zigpy-cc python39Packages.zigpy-deconz python39Packages.zigpy-xbee python39Packages.zigpy-zigate python39Packages.zigpy-znp

84 packages built:
adafruit-ampy chirp cura curaByDagoma curaLulzbot cura_stable esphome esptool grabserial inkcut inkscape-extensions.inkcut ino klipper mavproxy mpfshell nanovna-saver nrfutil octoprint platformio plover.dev plover.stable printrun pwntools python37Packages.bellows python37Packages.bme680 python37Packages.can python37Packages.canopen python37Packages.digi-xbee python37Packages.facedancer python37Packages.homeassistant-pyozw python37Packages.junos-eznc python37Packages.pwntools python37Packages.py3status python37Packages.pyserial python37Packages.pyserial-asyncio python37Packages.pyspinel python37Packages.python_openzwave python37Packages.pyuavcan python37Packages.smbus-cffi python37Packages.solo-python python37Packages.stm32loader python37Packages.zigpy-deconz python38Packages.bellows python38Packages.bme680 python38Packages.can python38Packages.canopen python38Packages.digi-xbee python38Packages.facedancer python38Packages.homeassistant-pyozw python38Packages.junos-eznc python38Packages.py3status python38Packages.pyserial python38Packages.pyserial-asyncio python38Packages.pyspinel python38Packages.python_openzwave python38Packages.pyuavcan python38Packages.smbus-cffi python38Packages.solo-python stm32loader python38Packages.zigpy-cc python38Packages.zigpy-deconz python38Packages.zigpy-xbee python38Packages.zigpy-zigate python39Packages.bme680 python39Packages.can python39Packages.canopen python39Packages.digi-xbee python39Packages.facedancer python39Packages.homeassistant-pyozw python39Packages.junos-eznc python39Packages.pwntools python39Packages.py3status python39Packages.pyserial python39Packages.pyserial-asyncio python39Packages.pyspinel python39Packages.python_openzwave python39Packages.pyuavcan python39Packages.smbus-cffi python39Packages.stm32loader rshell sumorobot-manager thonny tinyprog tockloader

@jonringer jonringer merged commit 1692d67 into NixOS:master Nov 30, 2020
@siriobalmelli siriobalmelli deleted the update/pyserial branch November 30, 2020 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants