Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3packages.bme680: Mark Linux only as upstream #105500

Merged
merged 1 commit into from Dec 1, 2020
Merged

python3packages.bme680: Mark Linux only as upstream #105500

merged 1 commit into from Dec 1, 2020

Conversation

SuperSandro2000
Copy link
Member

Motivation for this change

#105483 (review)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@mweinelt
Copy link
Member

mweinelt commented Dec 1, 2020

Can you mention your source?

https://github.com/pimoroni/bme680-python/blob/master/packaging/debian/control#L22

@Mic92
Copy link
Member

Mic92 commented Dec 1, 2020

Can you mention your source?

https://github.com/pimoroni/bme680-python/blob/master/packaging/debian/control#L22

Debian only packages for Linux and maybe kfreebsd. I am sure macOS will have different I2C interfaces.

@mweinelt
Copy link
Member

mweinelt commented Dec 1, 2020

Can you mention your source?
https://github.com/pimoroni/bme680-python/blob/master/packaging/debian/control#L22

Debian only packages for Linux and maybe kfreebsd. I am sure macOS will have different I2C interfaces.

Oh yeah, what I meant was, shouldn't this be platform.unix then? Or does that include Darwin as well?

@Mic92
Copy link
Member

Mic92 commented Dec 1, 2020

Can you mention your source?
https://github.com/pimoroni/bme680-python/blob/master/packaging/debian/control#L22

Debian only packages for Linux and maybe kfreebsd. I am sure macOS will have different I2C interfaces.

Oh yeah, what I meant was, shouldn't this be platform.unix then? Or does that include Darwin as well?

it does.

@Mic92 Mic92 merged commit d7a5482 into NixOS:master Dec 1, 2020
@SuperSandro2000 SuperSandro2000 deleted the bme680-linux branch August 26, 2021 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prusnak prusnak prusnak approved these changes

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

Assignees
No one assigned
Labels
6.topic: python 8.has: clean-up 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@SuperSandro2000 @mweinelt @Mic92 @prusnak