Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mojave-gtk-theme: 2020-03-19 -> 2020-11-29 #105508

Merged
merged 1 commit into from Dec 1, 2020
Merged

mojave-gtk-theme: 2020-03-19 -> 2020-11-29 #105508

merged 1 commit into from Dec 1, 2020

Conversation

chkno
Copy link
Member

@chkno chkno commented Nov 30, 2020

Motivation for this change

Resolves a size and performance regression introduced when libsass bumped 3.6.1 -> 3.6.3. With this change, this package's size shrinks from 1.5G to 31M and GTK applications start quickly again.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Determined the impact on package closure size (by running nix path-info -S before and after)
    1,833,380,816 → 271,684,768
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

FYI: maintainer @romildo

@chkno
mojave-gtk-theme: 2020-03-19 -> 2020-11-29
289da1d 
Resolves a size and performance regression introduced when libsass
bumped 3.6.1 -> 3.6.3.  With this change, this package's size shrinks
from 1.5G to 31M.

vinceliuice/Mojave-gtk-theme#178
@romildo romildo mentioned this pull request Nov 30, 2020
Closed
10 tasks
@ofborg ofborg bot requested a review from romildo November 30, 2020 23:01
@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 105508 run on x86_64-linux 1

1 package built:
  • mojave-gtk-theme

@SuperSandro2000 SuperSandro2000 merged commit 3a49465 into NixOS:master Dec 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@romildo romildo Awaiting requested review from romildo

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@chkno @SuperSandro2000