hdl-dump: init at 20202807 #105514
Merged
hdl-dump: init at 20202807 #105514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+6
to
+10
| let | ||
| version = "20202807"; | ||
| pname = "hdl-dump"; | ||
| in stdenv.mkDerivation { | ||
| inherit pname version; |
There was a problem hiding this comment.
Suggested change
| let | |
| version = "20202807"; | |
| pname = "hdl-dump"; | |
| in stdenv.mkDerivation { | |
| inherit pname version; | |
| stdenv.mkDerivation rec { | |
| pname = "hdl-dump"; | |
| version = "20202807"; |
pkgs/tools/misc/hdl-dump/default.nix
Outdated
| in stdenv.mkDerivation { | ||
| inherit pname version; | ||
|
|
||
| # playstation2 repo is outdated |
There was a problem hiding this comment.
Please add a link which one.
There was a problem hiding this comment.
It is implict, but I will update it nonetheless.
|
Result of 1 package marked as broken and skipped:
|
|
@AndersonTorres Thanks for picking up my contribution, i didn't have had much time to fix my PRs so i am glad you did 👍 |
makefu
approved these changes
Dec 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)