Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

factorio-experimental, factorio-headless-experimental: 1.1.2 -> 1.1.3 #105471

Merged
merged 1 commit into from Nov 30, 2020
Merged

factorio-experimental, factorio-headless-experimental: 1.1.2 -> 1.1.3 #105471

merged 1 commit into from Nov 30, 2020

Conversation

lukegb
Copy link
Contributor

@lukegb lukegb commented Nov 30, 2020

Motivation for this change

https://forums.factorio.com/92314

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@lukegb
Copy link
Contributor Author

lukegb commented Nov 30, 2020

Note that this includes #105296, since having written an update script I'm obviously going to use it :P

@ofborg ofborg bot requested review from erictapen, elitak and Baughn November 30, 2020 18:26
@SuperSandro2000
Copy link
Member

Note that this includes #105296, since having written an update script I'm obviously going to use it :P

Just merged that. Can you do a rebase?

@SuperSandro2000
Copy link
Member

SuperSandro2000 commented Nov 30, 2020 •
edited

Result of nixpkgs-review pr 105471 run on x86_64-linux 1

1 package failed to build:
  • factorio-experimental
1 package built:
  • factorio-headless-experimental

To lazy to download the full release.

@lukegb
Copy link
Contributor Author

lukegb commented Nov 30, 2020

Rebased.

erictapen
erictapen approved these changes Nov 30, 2020
View reviewed changes
Copy link
Member

@erictapen erictapen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Builds for me.

@erictapen erictapen merged commit f838208 into NixOS:master Nov 30, 2020
@lukegb lukegb deleted the factorio-1.1.3 branch December 5, 2022 01:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 approved these changes

@erictapen erictapen erictapen approved these changes

@elitak elitak Awaiting requested review from elitak

@Baughn Baughn Awaiting requested review from Baughn

Assignees
No one assigned
Labels
8.has: clean-up 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lukegb @SuperSandro2000 @erictapen