Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rocm: update to 3.10.0 #105474

Merged
merged 9 commits into from Dec 2, 2020
Merged

rocm: update to 3.10.0 #105474

merged 9 commits into from Dec 2, 2020

Conversation

danieldk
Copy link
Contributor

@danieldk danieldk commented Nov 30, 2020 •
edited

Motivation for this change

Update ROCm stack to 3.10.0.

This should not be merged until the PR is approved by @acowley and @Flakebi

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@danieldk danieldk marked this pull request as ready for review December 1, 2020 06:45
@danieldk
Copy link
Contributor Author

danieldk commented Dec 1, 2020

cc @acowley @Flakebi The next release of ROCm.

@danieldk danieldk changed the title WIP: rocm: update to 3.10.0 rocm: update to 3.10.0 Dec 1, 2020
@danieldk
Copy link
Contributor Author

danieldk commented Dec 1, 2020

@ofborg build rocm-opencl-icd

Flakebi
Flakebi approved these changes Dec 1, 2020
View reviewed changes
Copy link
Member

@Flakebi Flakebi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works fine with OpenCL examples, thanks!

Result of nixpkgs-review pr 105474 1

9 packages built:
  • rocclr
  • rocm-cmake
  • rocm-comgr
  • rocm-device-libs
  • rocm-opencl-icd
  • rocm-opencl-runtime
  • rocm-runtime
  • rocm-smi
  • rocm-thunk

acowley
acowley approved these changes Dec 1, 2020
View reviewed changes
Copy link
Contributor

@acowley acowley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is now working with hip in the overlay, too. Thank you!

@danieldk danieldk merged commit ebf687a into NixOS:master Dec 2, 2020
@danieldk danieldk deleted the rocm-3.10.0 branch December 2, 2020 05:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acowley acowley acowley approved these changes

@Flakebi Flakebi Flakebi approved these changes

@matthewbauer matthewbauer Awaiting requested review from matthewbauer

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@danieldk @acowley @Flakebi