Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lc3tools: fix errors due to incorrect hardcoded paths #105522

Merged
merged 1 commit into from Dec 8, 2020
Merged

lc3tools: fix errors due to incorrect hardcoded paths #105522

merged 1 commit into from Dec 8, 2020

Conversation

anna328p
Copy link
Member

@anna328p anna328p commented Dec 1, 2020

Motivation for this change

My previous PR for lc3tools had some breakage due to the upstream install scripts hardcoding executable and library paths. I have fixed the references to these paths so lc3sim and lc3sim-tk now run. (the previous PR, lc3convert and lc3as ran but I did not test the other executables)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 105522 run on x86_64-linux 1

1 package built:
  • lc3tools

jonringer
jonringer approved these changes Dec 8, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Result of nixpkgs-review pr 105522 1

1 package built:
  • lc3tools

@jonringer jonringer merged commit f4679d3 into NixOS:master Dec 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@anna328p @SuperSandro2000 @jonringer