Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rst2html5: 1.9.4 -> 1.10.6 #105489

Merged
merged 1 commit into from Nov 30, 2020
Merged

rst2html5: 1.9.4 -> 1.10.6 #105489

merged 1 commit into from Nov 30, 2020

Conversation

AndersonTorres
Copy link
Member

@AndersonTorres AndersonTorres commented Nov 30, 2020 •
edited

Motivation for this change

Now with wheels!

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@AndersonTorres AndersonTorres merged commit 7714edc into NixOS:master Nov 30, 2020
@AndersonTorres AndersonTorres deleted the update-rst2html5 branch November 30, 2020 21:42
SuperSandro2000
SuperSandro2000 reviewed Dec 1, 2020
View reviewed changes
pkgs/tools/text/rst2html5/default.nix
pname = "rst2html5";
version = "1.9.4";
version = "1.10.6";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are you always using let in? rec is 2 lines shorter and has less repetition. This makes only sense to use when you input another derivation, an icon or something similar.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rec scrambles the scope of its variables, and I don't think it is bad to "factor" a variable like pname.

@SuperSandro2000
Copy link
Member

Does not build for me:


trying https://files.pythonhosted.org/packages/source/r/rst2html5/rst2html5-1.10.6.tar.gz
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
curl: (22) The requested URL returned error: 404

trying https://pypi.io/packages/source/r/rst2html5/rst2html5-1.10.6.tar.gz
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100   122  100   122    0     0   1297      0 --:--:-- --:--:-- --:--:--  1297
100   279  100   279    0     0    948      0 --:--:-- --:--:-- --:--:--   948
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
curl: (22) The requested URL returned error: 404
error: cannot download rst2html5-1.10.6.tar.gz from any mirror
builder for '/nix/store/zsh16gcmqx6wmlgyha4gjvfywn81w7v2-rst2html5-1.10.6.tar.gz.drv' failed with exit code 1
cannot build derivation '/nix/store/kw9m16ip9f0asdw6qhj9b8wm78pf83ym-python3.8-rst2html5-1.10.6.drv': 1 dependencies couldn't be built
error: build of '/nix/store/kw9m16ip9f0asdw6qhj9b8wm78pf83ym-python3.8-rst2html5-1.10.6.drv' failed

@AndersonTorres Did the version get yanked?

@bobrik
Copy link
Contributor

bobrik commented Feb 27, 2021

The filename is different. Compare 1.9.4:

image

To 1.10.6:

image

@bobrik bobrik mentioned this pull request Feb 27, 2021
Merged
10 tasks
bobrik added a commit to bobrik/nixpkgs that referenced this pull request Feb 27, 2021
@bobrik
rst2html5: fix download now that it is a wheel
20dba8a 
Fixing up NixOS#105489.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 left review comments

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@AndersonTorres @SuperSandro2000 @bobrik