New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ideamaker: init at 4.0.1 #105520
Merged
Merged
ideamaker: init at 4.0.1 #105520
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Result of 2 packages built:
|
lovesegfault
force-pushed
the
ideamaker
branch
from
December 1, 2020 01:15
412b400
to
b46bbec
Compare
lovesegfault
force-pushed
the
ideamaker
branch
from
December 1, 2020 01:17
b46bbec
to
98d5377
Compare
@SuperSandro2000 I think I addressed most of the comments, thanks for the review! |
Result of 2 packages built:
|
lovesegfault
force-pushed
the
ideamaker
branch
from
December 1, 2020 11:05
98d5377
to
8c49bed
Compare
Result of 1 package built:
|
Result of 2 packages built:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
I wanted to try ideamaker out and noticed it wasn't packaged. One of its
dependencies, libcork, was also missing so I packaged it.
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)