Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gst-plugins-good: fix aarch64 builds and make raspi deps optional #105487

Merged
merged 1 commit into from Dec 5, 2020
Merged

gst-plugins-good: fix aarch64 builds and make raspi deps optional #105487

merged 1 commit into from Dec 5, 2020

Conversation

vikanezrimaya
Copy link
Member

Motivation for this change

Fixes #104099

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

nh2
nh2 approved these changes Dec 3, 2020
View reviewed changes
Copy link
Contributor

@nh2 nh2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks correct to me.

Maybe @samueldr may want to weigh in whether this fixes mobile NixOS builds?

@vikanezrimaya
Copy link
Member Author

@nh2 should this get more approvals or can we just merge that and get it over with? I'm kinda sad seeing aarch64 graphical closures failing on Hydra 😭

@nh2
Copy link
Contributor

nh2 commented Dec 5, 2020

@nh2 should this get more approvals

@kisik21 I don't think it's necessary, given that the chance that it fixes more than it breaks is very high. I just pinged @samueldr because I know that my change broke Mobile NixOS, and I don't have a NixOS aarch64 device to test it myself.

But I agree we shouldn't wait too long, thus merging.

@nh2 nh2 merged commit f1651e1 into NixOS:master Dec 5, 2020
@vikanezrimaya vikanezrimaya deleted the gst-plugins-good-aarch64 branch December 5, 2020 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nh2 nh2 nh2 approved these changes

@matthewbauer matthewbauer Awaiting requested review from matthewbauer

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

gst-plugins-good-1.18.0 does not build aarch64-linux
2 participants
@vikanezrimaya @nh2