Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

zfs: 0.8.5 -> 2.0.0 #105513

Merged
merged 1 commit into from Dec 1, 2020
Merged

zfs: 0.8.5 -> 2.0.0 #105513

merged 1 commit into from Dec 1, 2020

Conversation

jonringer
Copy link
Contributor

@jonringer jonringer commented Nov 30, 2020 •
edited

Motivation for this change

new release https://github.com/openzfs/zfs/releases/tag/zfs-2.0.0

also cleaned up some unused substitutions

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@jonringer
Copy link
Contributor Author

@GrahamcOfBorg test zfs.stable
@GrahamcOfBorg test zfs.unstable
@GrahamcOfBorg test zfs.installer

@ofborg ofborg bot requested review from wizeman, globin and fpletz November 30, 2020 23:21
hmenke
hmenke reviewed Dec 1, 2020
View reviewed changes
Copy link
Member

@hmenke hmenke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While you're at it, could you please also change the branding from zfsonlinux to openzfs? I don't know whether the redirects from zfsonlinux to openzfs will disappear.

Also would you mind adding myself (and probably yourself) as maintainers on this? All of the current maintainers don't seem to be very active on GitHub recently.

Mic92
Mic92 approved these changes Dec 1, 2020
View reviewed changes
Copy link
Member

@Mic92 Mic92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I came independently to the same diff: Mic92@896ff29

@Mic92
Copy link
Member

Mic92 commented Dec 1, 2020

You can also add me. I have around 9 systems with zfs and know stuff about kernels/filesystems.

@Mic92
Copy link
Member

Mic92 commented Dec 1, 2020

Result of nixpkgs-review pr 105513 1

10 packages marked as broken and skipped:
  • bareos
  • linuxPackages_hardkernel_4_14.zfs
  • linuxPackages_hardkernel_4_14.zfsStable
  • linuxPackages_hardkernel_4_14.zfsUnstable
  • linuxPackages_hardkernel_latest.zfs
  • linuxPackages_hardkernel_latest.zfsStable
  • linuxPackages_hardkernel_latest.zfsUnstable
  • nixops
  • nixopsUnstable
  • nixops_1_6_1
1 package blacklisted:
  • tests.nixos-functions.nixosTest-test
64 packages built:
  • ceph (ceph-dev)
  • ceph-client
  • collectd
  • collectd-data
  • docker-machine-kvm
  • docker-machine-kvm2
  • easysnap
  • gnome3.gnome-boxes
  • grub2 (grub2_full)
  • grub2_efi
  • grub2_pvgrub_image
  • grub2_xen
  • haskellPackages.libvirt-hs
  • haskellPackages.libzfs
  • libceph
  • libguestfs
  • libvirt
  • libvirt-glib
  • libvirt_5_9_0
  • libvmi
  • linuxPackages-libre.zfs (linuxPackages-libre.zfsStable ,linuxPackages-libre.zfsUnstable)
  • linuxPackages.zfs (linuxPackages.zfsStable ,linuxPackages.zfsUnstable ,linuxPackages_5_4.zfs ,linuxPackages_5_4.zfsStable ,linuxPackages_5_4.zfsUnstable)
  • linuxPackages_4_14.zfs (linuxPackages_4_14.zfsStable ,linuxPackages_4_14.zfsUnstable)
  • linuxPackages_4_19.zfs (linuxPackages_4_19.zfsStable ,linuxPackages_4_19.zfsUnstable)
  • linuxPackages_4_4.zfs (linuxPackages_4_4.zfsStable ,linuxPackages_4_4.zfsUnstable)
  • linuxPackages_4_9.zfs (linuxPackages_4_9.zfsStable ,linuxPackages_4_9.zfsUnstable)
  • linuxPackages_5_8.zfs (linuxPackages_5_8.zfsStable ,linuxPackages_5_8.zfsUnstable)
  • linuxPackages_5_9.zfs (linuxPackages_5_9.zfsStable ,linuxPackages_5_9.zfsUnstable ,linuxPackages_latest.zfs ,linuxPackages_latest.zfsStable ,linuxPackages_latest.zfsUnstable)
  • linuxPackages_hardened.zfs (linuxPackages_hardened.zfsStable ,linuxPackages_hardened.zfsUnstable)
  • linuxPackages_latest-libre.zfs (linuxPackages_latest-libre.zfsStable ,linuxPackages_latest-libre.zfsUnstable)
  • linuxPackages_latest_hardened.zfs (linuxPackages_latest_hardened.zfsStable ,linuxPackages_latest_hardened.zfsUnstable)
  • linuxPackages_latest_xen_dom0.zfs (linuxPackages_latest_xen_dom0.zfsStable ,linuxPackages_latest_xen_dom0.zfsUnstable)
  • linuxPackages_latest_xen_dom0_hardened.zfs (linuxPackages_latest_xen_dom0_hardened.zfsStable ,linuxPackages_latest_xen_dom0_hardened.zfsUnstable)
  • linuxPackages_testing_bcachefs.zfs (linuxPackages_testing_bcachefs.zfsStable ,linuxPackages_testing_bcachefs.zfsUnstable)
  • linuxPackages_xen_dom0.zfs (linuxPackages_xen_dom0.zfsStable ,linuxPackages_xen_dom0.zfsUnstable)
  • linuxPackages_xen_dom0_hardened.zfs (linuxPackages_xen_dom0_hardened.zfsStable ,linuxPackages_xen_dom0_hardened.zfsUnstable)
  • linuxPackages_zen.zfs (linuxPackages_zen.zfsStable ,linuxPackages_zen.zfsUnstable)
  • minikube
  • minishift
  • os-prober
  • perl530Packages.SysVirt
  • perl532Packages.SysVirt
  • python37Packages.guestfs
  • python37Packages.libvirt
  • python38Packages.guestfs
  • python38Packages.libvirt
  • python39Packages.guestfs
  • python39Packages.libvirt
  • rubyPackages.ruby-libvirt (rubyPackages_2_6.ruby-libvirt)
  • rubyPackages_2_5.ruby-libvirt
  • rubyPackages_2_7.ruby-libvirt
  • sambaFull (samba4Full)
  • sanoid
  • terraform-full
  • terraform-providers.libvirt
  • terraform_0_11-full
  • vagrant
  • virt-manager
  • virt-manager-qt
  • virt-top
  • virt-viewer
  • virtlyst
  • zfs (zfsStable ,zfsUnstable)
  • zfstools

@Mic92 Mic92 merged commit e346906 into NixOS:master Dec 1, 2020
@jonringer jonringer deleted the bump-zfs-stable branch December 1, 2020 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hmenke hmenke hmenke left review comments

@Mic92 Mic92 Mic92 approved these changes

@grahamc grahamc Awaiting requested review from grahamc

@wizeman wizeman Awaiting requested review from wizeman

@globin globin Awaiting requested review from globin

@fpletz fpletz Awaiting requested review from fpletz

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 101-500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jonringer @Mic92 @hmenke