Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

desync: 0.4.0 -> 0.9.0 #106403

Merged
merged 1 commit into from Jan 1, 2021
Merged

desync: 0.4.0 -> 0.9.0 #106403

merged 1 commit into from Jan 1, 2021

Conversation

charles-dyfis-net
Copy link
Contributor

@charles-dyfis-net charles-dyfis-net commented Dec 9, 2020 •
edited

Motivation for this change

The desync package has fallen far behind upstream, and consequently missed out on a great deal of feature and bugfix development.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
    46,885,312 -> 51,176,648 -- an increase, but not an out-of-range one given the dependency chain updates supporting new features.
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

doronbehar
doronbehar requested changes Dec 16, 2020
View reviewed changes
Copy link
Contributor

@doronbehar doronbehar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Upstream uses go modules now. Could you please also update the derivation to use buildGoModule? And remove deps.nix.

@charles-dyfis-net
Copy link
Contributor Author

@doronbehar done, thank you -- I hadn't been aware of buildGoModule.

That said, with the cutover, the tests are no longer able to succeed -- it looks like the data they need at runtime (stored in the testdata and cmd/desync/testdata subdirectories of the desync source tree) is unavailable. I don't see any hints in the buildGoModule documentation on how to address that; would you have guidance?

@ofborg ofborg bot requested a review from kalbasit December 29, 2020 21:23
doronbehar
doronbehar requested changes Dec 30, 2020
View reviewed changes
Copy link
Contributor

@doronbehar doronbehar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you could please squash the commits - migrating to buildGoModule is part of the update.

pkgs/applications/networking/sync/desync/default.nix Outdated Show resolved Hide resolved
@doronbehar doronbehar merged commit f0faa10 into NixOS:master Jan 1, 2021
@doronbehar
Copy link
Contributor

I don't see any hints in the buildGoModule documentation on how to address that; would you have guidance?

Me too 😕 . Tried to debug this a bit locally and failed to see why.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@doronbehar doronbehar doronbehar approved these changes

@kalbasit kalbasit Awaiting requested review from kalbasit

Assignees
No one assigned
Labels
8.has: clean-up 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@charles-dyfis-net @doronbehar