Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.tldextract: add missing dependency #106420

Merged
merged 1 commit into from Dec 11, 2020
Merged

pythonPackages.tldextract: add missing dependency #106420

merged 1 commit into from Dec 11, 2020

Conversation

IvarWithoutBones
Copy link
Member

Motivation for this change

Noticed this package was broken when upgrading my system, this adds a missing dependency making it build again.

Should be backported as well.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@sikmir sikmir mentioned this pull request Dec 9, 2020
Merged
10 tasks
@fabaff fabaff mentioned this pull request Dec 9, 2020
Closed
10 tasks
@SuperSandro2000 SuperSandro2000 added the 9.needs: port to stable A PR needs a backport to the stable release. label Dec 9, 2020
@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 106420 run on x86_64-linux 1

1 package failed to build:
  • lexicon
5 packages built:
  • python37Packages.tldextract
  • python38Packages.tldextract
  • python39Packages.tldextract
  • qutebrowser
  • sewer

@SuperSandro2000
Copy link
Member

Please add doCheck = false; and pythonImportsCheck.

sewer.log
176:Ran 0 tests in 0.000s

python37Packages.tldextract.log
146:Ran 0 tests in 0.000s

python39Packages.tldextract.log
146:Ran 0 tests in 0.000s

python38Packages.tldextract.log
146:Ran 0 tests in 0.000

Lexicon fails with:

builder for '/nix/store/j56giwlbqz09vmxgxxa2bjpv977rwh2n-lexicon-3.4.3.drv' failed with exit code 1; last 10 log lines:                                                                       Successfully built dns-lexicon                                                                                                                                                              Finished creating a wheel...                                                                                                                                                                Finished executing pipBuildPhase                                                                                                                                                            installing                                                                                                                                                                                  Executing pipInstallPhase                                                                                                                                                                   /build/source/dist /build/source                                                                                                                                                            Processing ./dns_lexicon-3.4.3-py3-none-any.whl                                                                                                                                             Requirement already satisfied: future<1,>=0 in /nix/store/p2ha6p5zlsl571g2f3kn5mhnfganhihh-python3.8-future-0.18.2/lib/python3.8/site-packages (from dns-lexicon==3.4.3) (0.18.2)           ERROR: Could not find a version that satisfies the requirement tldextract<3,>=2 (from dns-lexicon)                                                                                          ERROR: No matching distribution found for tldextract<3,>=2                                                                                                                                cannot build derivation '/nix/store/538229lvxi89a32lq1dj947b1d4c6gdy-env.drv': 1 dependencies couldn't be built                                                                             error: --- Error ----------------------------------------------------------------------------------------------------------------------------------------------------------------------- nixbuild of '/nix/store/538229lvxi89a32lq1dj947b1d4c6gdy-env.drv' failed

@IvarWithoutBones
Copy link
Member Author

Please add doCheck = false; and pythonImportsCheck.

Done 👍

Lexicon fails

Looks like this is an issue with the lexicon derivation itself, which i think can be fixed in a seperate PR.

@emmanuelrosa emmanuelrosa mentioned this pull request Dec 10, 2020
Closed
@SuperSandro2000 SuperSandro2000 merged commit 9b9ac64 into NixOS:master Dec 11, 2020
@IvarWithoutBones IvarWithoutBones deleted the fix-tldextract branch December 11, 2020 13:47
@IvarWithoutBones IvarWithoutBones mentioned this pull request Dec 14, 2020
Merged
10 tasks
@erictapen erictapen added 8.has: port to stable A PR already has a backport to the stable release. and removed 9.needs: port to stable A PR needs a backport to the stable release. labels Jan 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sikmir sikmir sikmir approved these changes

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

Assignees
No one assigned
Labels
6.topic: python 8.has: port to stable A PR already has a backport to the stable release. 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@IvarWithoutBones @SuperSandro2000 @sikmir @erictapen