Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

http-getter: unstable-2018-06-06 -> unstable-2020-12-08 #106419

Merged
merged 1 commit into from Dec 9, 2020
Merged

http-getter: unstable-2018-06-06 -> unstable-2020-12-08 #106419

merged 1 commit into from Dec 9, 2020

Conversation

r-burns
Copy link
Contributor

@r-burns r-burns commented Dec 9, 2020

Fixes build on darwin. No functional changes.

Diff: tohojo/http-getter@79bcccc...0b20f08

Can be backported to 20.09.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@r-burns
http-getter: unstable-2018-06-06 -> unstable-2020-12-08
fb0f4a2 
Fixes build on darwin. No functional changes.
@r-burns
Copy link
Contributor Author

r-burns commented Dec 9, 2020

Result of nixpkgs-review run on x86_64-darwin 1

1 package built:
  • http-getter

@SuperSandro2000
Copy link
Member

Can be backported to 20.09.

Is there any reason besides the update?

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 106419 1 on darwin

1 package built:
  • http-getter

@r-burns
Copy link
Contributor Author

r-burns commented Dec 9, 2020

Is there any reason besides the update?

It fixes the build on darwin

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 106419 run on x86_64-linux 1

1 package built:
  • http-getter

@SuperSandro2000 SuperSandro2000 merged commit cd22d25 into NixOS:master Dec 9, 2020
@SuperSandro2000
Copy link
Member

It fixes the build on darwin

There are so many fixes for darwin that it is probably not worth it to backport such packages.

@r-burns r-burns deleted the http-getter branch December 30, 2020 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@r-burns @SuperSandro2000