Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.soco: fixup and adopt #106405

Merged
merged 1 commit into from Dec 9, 2020
Merged

python3Packages.soco: fixup and adopt #106405

merged 1 commit into from Dec 9, 2020

Conversation

lovesegfault
Copy link
Member

Motivation for this change

The package is currently failing to build and, in turn, breaking beets.

This fixes the build, as well as add me as maintainer, since the package was
orphaned.

cc. @jonringer, @SuperSandro2000

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@lovesegfault
Copy link
Member Author

Result of nixpkgs-review pr 106405 run on x86_64-linux 1

4 packages built:
  • beets
  • python37Packages.soco
  • python38Packages.soco
  • python39Packages.soco

mweinelt
mweinelt reviewed Dec 9, 2020
View reviewed changes
Copy link
Member

@mweinelt mweinelt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was preparing the same change because of beets, so I have a few remarks from when I tried fixing this locally.

pkgs/development/python-modules/soco/default.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/soco/default.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/soco/default.nix Show resolved Hide resolved
@mweinelt mweinelt merged commit 56c1a32 into NixOS:master Dec 9, 2020
@lovesegfault lovesegfault deleted the pythonPackages.soco-fix branch December 9, 2020 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mweinelt mweinelt mweinelt approved these changes

@jonringer jonringer jonringer approved these changes

@FRidh FRidh Awaiting requested review from FRidh

@SuperSandro2000 SuperSandro2000 Awaiting requested review from SuperSandro2000

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@lovesegfault @mweinelt @SuperSandro2000 @jonringer