Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.pytorch: Fix CMake files for split outputs #105772

Merged
merged 1 commit into from Dec 4, 2020
Merged

python3Packages.pytorch: Fix CMake files for split outputs #105772

merged 1 commit into from Dec 4, 2020

Conversation

danieldk
Copy link
Contributor

@danieldk danieldk commented Dec 3, 2020

Motivation for this change

Fixes #102146

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@danieldk danieldk mentioned this pull request Dec 3, 2020
Merged
10 tasks
@danieldk
Copy link
Contributor Author

danieldk commented Dec 3, 2020

@ofborg build python37Packages.pytorch python38Packages.pytorch

@ofborg ofborg bot requested review from thoughtpolice and teh December 3, 2020 08:04
@teh
Copy link
Contributor

teh commented Dec 3, 2020

Is the aarch64 failure related to this change or an existing problem?

@danieldk
Copy link
Contributor Author

danieldk commented Dec 3, 2020

Is the aarch64 failure related to this change or an existing problem?

That's #102518 , which has only landed in staging.

@SuperSandro2000
Copy link
Member

@ofborg build python39Packages.pytorch

@danieldk
Copy link
Contributor Author

danieldk commented Dec 3, 2020 •
edited

Note that upstream will only support Python 3.9 in 1.7.1.

Edit: nice that it builds anyway.

@danieldk danieldk merged commit ac5bd14 into NixOS:master Dec 4, 2020
@danieldk danieldk deleted the pytorch-fixup-cmake branch December 4, 2020 05:53
@danieldk
Copy link
Contributor Author

danieldk commented Dec 4, 2020

@teh thanks for the review!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teh teh teh approved these changes

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

@thoughtpolice thoughtpolice Awaiting requested review from thoughtpolice

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

cmake config for pytorch seems to be broken
3 participants
@danieldk @teh @SuperSandro2000