Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

terraform_0_14: init at 0.14.0 #105746

Merged
merged 1 commit into from Dec 3, 2020
Merged

terraform_0_14: init at 0.14.0 #105746

merged 1 commit into from Dec 3, 2020

Conversation

marsam
Copy link
Contributor

@marsam marsam commented Dec 3, 2020

Motivation for this change

https://github.com/hashicorp/terraform/releases/tag/v0.14.0

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@marsam
Copy link
Contributor Author

marsam commented Dec 3, 2020

@GrahamcOfBorg build terraform_0_11 terraform_0_12 terraform_0_13 terraform_0_14

@SuperSandro2000
Copy link
Member

Should we consider removing 0.11 eventually?

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 105746 run on x86_64-linux 1

7 packages built:
  • terraform (terraform_0_12)
  • terraform-full
  • terraform_0_11
  • terraform_0_11-full
  • terraform_0_13
  • terraform_0_14
  • terraform_plugins_test

@zimbatm
Copy link
Member

zimbatm commented Dec 3, 2020

Yes, let's remove 0.11. We try to keep at most 3 of each language.

@zimbatm zimbatm merged commit 209bdc8 into NixOS:master Dec 3, 2020
@zimbatm
Copy link
Member

zimbatm commented Dec 3, 2020

Removal of 0.11 can be done in another PR

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 105746 run on x86_64-darwin 1

2 packages marked as broken and skipped:
  • terraform-full
  • terraform_0_11-full
4 packages built:
  • terraform (terraform_0_12)
  • terraform_0_11
  • terraform_0_13
  • terraform_0_14

@marsam marsam mentioned this pull request Dec 8, 2020
Merged
10 tasks
anandsuresh pushed a commit to anandsuresh/nixpkgs that referenced this pull request Jan 27, 2021
@marsam @anandsuresh
terraform_0_14: init at 0.14.0 (NixOS#105746)
71688f6 
https://github.com/hashicorp/terraform/releases/tag/v0.14.0
(cherry picked from commit 209bdc8)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zimbatm zimbatm Awaiting requested review from zimbatm

@kalbasit kalbasit Awaiting requested review from kalbasit

@babariviere babariviere Awaiting requested review from babariviere

@peterhoeg peterhoeg Awaiting requested review from peterhoeg

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@marsam @SuperSandro2000 @zimbatm