New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
buildbot: 2.8.4-> 2.9.2 #105935
buildbot: 2.8.4-> 2.9.2 #105935
Conversation
The Jade language was renamed to Pug, and this is the new Python package to support it. It is also better maintained than pyjade.
pyjade is superseded by pypugjs and was only used by buildbot
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@@ -5181,8 +5181,6 @@ in { | |||
|
|||
pyipp = callPackage ../development/python-modules/pyipp { }; | |||
|
|||
pyjade = callPackage ../development/python-modules/pyjade { }; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to add an alias which throws the removal?
Result of 3 packages failed to build:
30 packages built:
Python3.9 failures are due to boto failure. Please disable tests and do pythonImportsCheck.
|
Result of 12 packages failed to build:
21 packages built:
Tests fail due to darwin sandbox. |
2.9.1 has been released, so I have updated this PR. |
@GrahamcOfBorg build buildbot |
I have updated this PR to include pypugjs 5.9.7 and buildbot 2.9.2. |
Result of 30 packages built:
|
One more update, pypugjs 5.9.8 allows us to fetch from PyPI. All of the issues I ran into with pypugjs have now been resolved upstream and released. |
Motivation for this change
Updates buildbot to the latest version: https://github.com/buildbot/buildbot/releases/tag/v2.9.0
pyjade has been replaced with pypugjs. This is mostly just a rename due to trademark issues, but pypugjs is also better maintained than pyjade was. I removed pyjade because buildbot was the only user and it is obsolete now.
cc @nand0p @ryansydnor
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)