Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

buildbot: 2.8.4-> 2.9.2 #105935

Merged
merged 8 commits into from Dec 9, 2020
Merged

buildbot: 2.8.4-> 2.9.2 #105935

merged 8 commits into from Dec 9, 2020

Conversation

lopsided98
Copy link
Contributor

Motivation for this change

Updates buildbot to the latest version: https://github.com/buildbot/buildbot/releases/tag/v2.9.0

pyjade has been replaced with pypugjs. This is mostly just a rename due to trademark issues, but pypugjs is also better maintained than pyjade was. I removed pyjade because buildbot was the only user and it is obsolete now.

cc @nand0p @ryansydnor

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

The Jade language was renamed to Pug, and this is the new Python package to
support it. It is also better maintained than pyjade.
pyjade is superseded by pypugjs and was only used by buildbot
Copy link
Member

@veprbl veprbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -5181,8 +5181,6 @@ in {

pyipp = callPackage ../development/python-modules/pyipp { };

pyjade = callPackage ../development/python-modules/pyjade { };
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to add an alias which throws the removal?

@SuperSandro2000
Copy link
Member

SuperSandro2000 commented Dec 5, 2020

Result of nixpkgs-review pr 105935 run on x86_64-linux 1

3 packages failed to build:
  • python39Packages.buildbot
  • python39Packages.buildbot-full
  • python39Packages.buildbot-ui
30 packages built:
  • buildbot (python38Packages.buildbot)
  • buildbot-full (python38Packages.buildbot-full)
  • buildbot-ui (python38Packages.buildbot-ui)
  • buildbot-worker (python38Packages.buildbot-worker)
  • python37Packages.buildbot
  • python37Packages.buildbot-full
  • python37Packages.buildbot-pkg
  • python37Packages.buildbot-plugins.console-view
  • python37Packages.buildbot-plugins.grid-view
  • python37Packages.buildbot-plugins.waterfall-view
  • python37Packages.buildbot-plugins.wsgi-dashboards
  • python37Packages.buildbot-plugins.www
  • python37Packages.buildbot-ui
  • python37Packages.buildbot-worker
  • python37Packages.pypugjs
  • python38Packages.buildbot-pkg
  • python38Packages.buildbot-plugins.console-view
  • python38Packages.buildbot-plugins.grid-view
  • python38Packages.buildbot-plugins.waterfall-view
  • python38Packages.buildbot-plugins.wsgi-dashboards
  • python38Packages.buildbot-plugins.www
  • python38Packages.pypugjs
  • python39Packages.buildbot-pkg
  • python39Packages.buildbot-plugins.console-view
  • python39Packages.buildbot-plugins.grid-view
  • python39Packages.buildbot-plugins.waterfall-view
  • python39Packages.buildbot-plugins.wsgi-dashboards
  • python39Packages.buildbot-plugins.www
  • python39Packages.buildbot-worker
  • python39Packages.pypugjs

Python3.9 failures are due to boto failure.

Please disable tests and do pythonImportsCheck.

python38Packages.buildbot-pkg.log                                                                                                                                                           107:Ran 0 tests in 0.000s                                                                                                                                                                                                                                                                                                                                                               python37Packages.buildbot-pkg.log                                                                                                                                                           107:Ran 0 tests in 0.000s                                                                                                                                                                                                                                                                                                                                                               python39Packages.buildbot-pkg.log                                                                                                                                                           107:Ran 0 tests in 0.000s

@SuperSandro2000
Copy link
Member

SuperSandro2000 commented Dec 5, 2020

Result of nixpkgs-review pr 105935 run on x86_64-darwin 1

12 packages failed to build:
  • buildbot (python38Packages.buildbot)
  • buildbot-full (python38Packages.buildbot-full)
  • buildbot-ui (python38Packages.buildbot-ui)
  • buildbot-worker (python38Packages.buildbot-worker)
  • python37Packages.buildbot
  • python37Packages.buildbot-full
  • python37Packages.buildbot-ui
  • python37Packages.buildbot-worker
  • python39Packages.buildbot
  • python39Packages.buildbot-full
  • python39Packages.buildbot-ui
  • python39Packages.buildbot-worker
21 packages built:
  • python37Packages.buildbot-pkg
  • python37Packages.buildbot-plugins.console-view
  • python37Packages.buildbot-plugins.grid-view
  • python37Packages.buildbot-plugins.waterfall-view
  • python37Packages.buildbot-plugins.wsgi-dashboards
  • python37Packages.buildbot-plugins.www
  • python37Packages.pypugjs
  • python38Packages.buildbot-pkg
  • python38Packages.buildbot-plugins.console-view
  • python38Packages.buildbot-plugins.grid-view
  • python38Packages.buildbot-plugins.waterfall-view
  • python38Packages.buildbot-plugins.wsgi-dashboards
  • python38Packages.buildbot-plugins.www
  • python38Packages.pypugjs
  • python39Packages.buildbot-pkg
  • python39Packages.buildbot-plugins.console-view
  • python39Packages.buildbot-plugins.grid-view
  • python39Packages.buildbot-plugins.waterfall-view
  • python39Packages.buildbot-plugins.wsgi-dashboards
  • python39Packages.buildbot-plugins.www
  • python39Packages.pypugjs

Tests fail due to darwin sandbox.

@lopsided98 lopsided98 changed the title buildbot: 2.8.4-> 2.9.0 buildbot: 2.8.4-> 2.9.1 Dec 5, 2020
@lopsided98
Copy link
Contributor Author

2.9.1 has been released, so I have updated this PR.

@FRidh
Copy link
Member

FRidh commented Dec 6, 2020

@GrahamcOfBorg build buildbot

@lopsided98
Copy link
Contributor Author

I have updated this PR to include pypugjs 5.9.7 and buildbot 2.9.2.

@lopsided98 lopsided98 changed the title buildbot: 2.8.4-> 2.9.1 buildbot: 2.8.4-> 2.9.2 Dec 9, 2020
@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 105935 run on x86_64-linux 1

30 packages built:
  • buildbot (python38Packages.buildbot)
  • buildbot-full (python38Packages.buildbot-full)
  • buildbot-ui (python38Packages.buildbot-ui)
  • buildbot-worker (python38Packages.buildbot-worker)
  • python37Packages.buildbot
  • python37Packages.buildbot-full
  • python37Packages.buildbot-pkg
  • python37Packages.buildbot-plugins.console-view
  • python37Packages.buildbot-plugins.grid-view
  • python37Packages.buildbot-plugins.waterfall-view
  • python37Packages.buildbot-plugins.wsgi-dashboards
  • python37Packages.buildbot-plugins.www
  • python37Packages.buildbot-ui
  • python37Packages.buildbot-worker
  • python37Packages.pypugjs
  • python38Packages.buildbot-pkg
  • python38Packages.buildbot-plugins.console-view
  • python38Packages.buildbot-plugins.grid-view
  • python38Packages.buildbot-plugins.waterfall-view
  • python38Packages.buildbot-plugins.wsgi-dashboards
  • python38Packages.buildbot-plugins.www
  • python38Packages.pypugjs
  • python39Packages.buildbot-pkg
  • python39Packages.buildbot-plugins.console-view
  • python39Packages.buildbot-plugins.grid-view
  • python39Packages.buildbot-plugins.waterfall-view
  • python39Packages.buildbot-plugins.wsgi-dashboards
  • python39Packages.buildbot-plugins.www
  • python39Packages.buildbot-worker
  • python39Packages.pypugjs

@lopsided98
Copy link
Contributor Author

One more update, pypugjs 5.9.8 allows us to fetch from PyPI. All of the issues I ran into with pypugjs have now been resolved upstream and released.

@veprbl veprbl merged commit 29d9cd8 into NixOS:master Dec 9, 2020
@lopsided98 lopsided98 deleted the buildbot-update branch December 10, 2020 01:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants