Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pass-import: 2.6 -> 3.1 #105919

Merged
merged 2 commits into from Dec 6, 2020
Merged

pass-import: 2.6 -> 3.1 #105919

merged 2 commits into from Dec 6, 2020

Conversation

Ma27
Copy link
Member

@Ma27 Ma27 commented Dec 4, 2020

Motivation for this change

ChangeLog in https://github.com/roddhjav/pass-import/blob/v3.1/CHANGELOG.rst#31---2020-10-25

For further details, please read the commit messages.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Ma27 and others added 2 commits December 4, 2020 22:33
@Ma27 @elseym
passExtensions.pass-import: 2.6 -> 3.1
2b67491 
ChangeLog: https://github.com/roddhjav/pass-import/blob/v3.1/CHANGELOG.rst#31---2020-10-25

* Make sure that all features are enabled by adding `pykeepass`,
  `filemagic` etc.

* Patch & use `setup.py` to make sure that everything gets installed
  properly into `$out`.

Co-authored-by: elseym <elseym@me.com>
@Ma27 @elseym
pass: support extensions with $out/bin
05348ed 
An example for that would be `passExtensions.pass-import` where
`pimport` is available in `$out/bin`. In that case, `$out/bin` in
`buildEnv` isn't a symlink anymore and doesn't need to be removed.

Co-authored-by: elseym <elseym@me.com>
@ofborg ofborg bot requested review from fpletz and tadfisher December 4, 2020 21:47
@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 105919 run on x86_64-linux 1

3 packages built:
  • krunner-pass
  • passExtensions.pass-import
  • rofi-pass

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 105919 run on x86_64-darwin 1

1 package marked as broken and skipped:
  • krunner-pass
1 package built:
  • passExtensions.pass-import

@Ma27
Copy link
Member Author

Ma27 commented Dec 6, 2020

@SuperSandro2000 anything missing to merge? :)

@Ma27 Ma27 merged commit 96d8d94 into NixOS:master Dec 6, 2020
@Ma27 Ma27 deleted the bump-pass-import branch December 6, 2020 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fpletz fpletz Awaiting requested review from fpletz

@tadfisher tadfisher Awaiting requested review from tadfisher

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Ma27 @SuperSandro2000