Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libff: shared build on darwin #105937

Merged
merged 1 commit into from Dec 11, 2020
Merged

libff: shared build on darwin #105937

merged 1 commit into from Dec 11, 2020

Conversation

arcz
Copy link
Member

@arcz arcz commented Dec 5, 2020

Motivation for this change

CMake is hardcoded to always build static library which causes linker failure for Haskell applications depending haskellPackages.hevm on macOS. This fixes the issue.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 105937 run on x86_64-darwin 1

2 packages built:
  • haskellPackages.hevm
  • libff

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 105937 run on x86_64-linux 1

2 packages built:
  • haskellPackages.hevm
  • libff

@jonringer
Copy link
Contributor

I'll merge when ofborg finishes

@jonringer
Copy link
Contributor

arch build would be a pre-existing failure

@jonringer jonringer merged commit 5a33e44 into NixOS:master Dec 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants