Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gmqcc: init at unstable-2020-10-27 #105903

Closed
wants to merge 1 commit into from
Closed

Conversation

illiusdope
Copy link
Contributor

Motivation for this change

A modern QuakeC compiler. I decided to put it in development/compilers rather than games because it's only a compiler.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Comment on lines +17 to +23
# Install Binaries
mkdir -pv $out/bin
cp -v {gmqcc,qcvm} $out/bin/

# Install man pages
mkdir -pv $out/share/man/man1
cp -v doc/{gmqcc,qcvm}.1 $out/share/man/man1/
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# Install Binaries
mkdir -pv $out/bin
cp -v {gmqcc,qcvm} $out/bin/
# Install man pages
mkdir -pv $out/share/man/man1
cp -v doc/{gmqcc,qcvm}.1 $out/share/man/man1/
mkdir $out/bin
cp {gmqcc,qcvm} $out/bin/
installManPage doc/*.1

@@ -0,0 +1,33 @@
{ stdenv, fetchFromGitHub }:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
{ stdenv, fetchFromGitHub }:
{ stdenv, fetchFromGitHub, installShellFiles }:

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 105903 run on x86_64-linux 1

1 package built:
  • gmqcc

@stale
Copy link

stale bot commented Jul 19, 2021

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jul 19, 2021
@NickCao
Copy link
Member

NickCao commented Jan 26, 2023

superseded by #176565

@NickCao NickCao closed this Jan 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants