-
-
Notifications
You must be signed in to change notification settings - Fork 15.5k
mmh: fix static build #105923
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mmh: fix static build #105923
Conversation
@@ -1,4 +1,4 @@ | |||
{ stdenv, fetchurl, ncurses, autoreconfHook, flex }: | |||
{ stdenv, fetchurl, ncurses, autoreconfHook, flex, lib }: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
{ stdenv, fetchurl, ncurses, autoreconfHook, flex, lib }: | |
{ stdenv, fetchurl, ncurses, autoreconfHook, flex }: |
@SuperSandro2000 Applied. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some suggestions
Okay, switched to use cc.targetPrefix to get rid of conditionals. @veprbl |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)