Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mmh: fix static build #105923

Merged
merged 1 commit into from Jan 5, 2021
Merged

mmh: fix static build #105923

merged 1 commit into from Jan 5, 2021

Conversation

KAction
Copy link
Contributor

@KAction KAction commented Dec 4, 2020

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

SuperSandro2000
SuperSandro2000 reviewed Dec 5, 2020
View reviewed changes
pkgs/applications/networking/mailreaders/mmh/default.nix Outdated
@@ -1,4 +1,4 @@
{ stdenv, fetchurl, ncurses, autoreconfHook, flex }:
{ stdenv, fetchurl, ncurses, autoreconfHook, flex, lib }:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
{ stdenv, fetchurl, ncurses, autoreconfHook, flex, lib }:
{ stdenv, fetchurl, ncurses, autoreconfHook, flex }:

@KAction
Copy link
Contributor Author

KAction commented Dec 15, 2020

@SuperSandro2000 Applied.

@veprbl veprbl added 6.topic: cross-compilation Building packages on a different sort platform than than they will be run on 6.topic: static labels Dec 15, 2020
veprbl
veprbl reviewed Dec 15, 2020
View reviewed changes
Copy link
Member

@veprbl veprbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions

@KAction
Copy link
Contributor Author

KAction commented Jan 1, 2021

Okay, switched to use cc.targetPrefix to get rid of conditionals. @veprbl

veprbl
veprbl approved these changes Jan 2, 2021
View reviewed changes
Copy link
Member

@veprbl veprbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@symphorien symphorien merged commit 7abb5bd into NixOS:master Jan 5, 2021
@KAction KAction deleted the mmh-static branch October 29, 2021 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 left review comments

@veprbl veprbl veprbl approved these changes

Assignees
No one assigned
Labels
6.topic: cross-compilation Building packages on a different sort platform than than they will be run on 6.topic: static 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@KAction @veprbl @SuperSandro2000 @symphorien