Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3Packages.sslyze: 3.0.0 -> 3.1.0 #105905

Merged
merged 3 commits into from Jan 12, 2021
Merged

python3Packages.sslyze: 3.0.0 -> 3.1.0 #105905

merged 3 commits into from Jan 12, 2021

Conversation

veehaitch
Copy link
Member

@veehaitch veehaitch commented Dec 4, 2020

Motivation for this change

Update to version 3.1.0

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 105905 run on x86_64-linux 1

1 package failed to build:
  • python39Packages.sslyze
5 packages built:
  • python37Packages.nassl
  • python37Packages.sslyze
  • python38Packages.nassl
  • sslyze (python38Packages.sslyze)
  • python39Packages.nassl

@veehaitch
Copy link
Member Author

Result of nixpkgs-review pr 105905 run on x86_64-linux 1
1 package failed to build:
5 packages built:

A test for random2 (sslyze -> faker -> random2) fails due to a change introduced in Python 3.9. I added a commit which patches random2 accordingly. Should be fine now.

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 105905 run on x86_64-darwin 1

14 packages marked as broken and skipped:
  • gscan2pdf
  • mailman-web
  • odpdown
  • pysolfc
  • python37Packages.mailman-web
  • python37Packages.qasm2image
  • python37Packages.rl-coach
  • python37Packages.toggl-cli
  • python38Packages.mailman-web
  • python38Packages.qasm2image
  • python38Packages.toggl-cli
  • python39Packages.mailman-web
  • python39Packages.qasm2image
  • python39Packages.toggl-cli
38 packages failed to build:
  • prospector
  • python37Packages.django_extensions
  • python37Packages.django_silk
  • python37Packages.nassl
  • python37Packages.pylint-django
  • python37Packages.qiskit
  • python37Packages.qiskit-aqua
  • python37Packages.scrapy-fake-useragent
  • python37Packages.sslyze
  • python38Packages.django_extensions
  • python38Packages.django_silk
  • python38Packages.nassl
  • python38Packages.pylint-django
  • python38Packages.qiskit
  • python38Packages.qiskit-aqua
  • python38Packages.scrapy-fake-useragent
  • sslyze (python38Packages.sslyze)
  • python39Packages.Quandl (python39Packages.quandl)
  • python39Packages.afdko
  • python39Packages.booleanoperations
  • python39Packages.defcon
  • python39Packages.django_extensions
  • python39Packages.django_silk
  • python39Packages.fontmath
  • python39Packages.fontparts
  • python39Packages.fontpens
  • python39Packages.fonttools
  • python39Packages.mutatormath
  • python39Packages.nassl
  • python39Packages.nototools
  • python39Packages.psautohint
  • python39Packages.pylint-django
  • python39Packages.qiskit
  • python39Packages.qiskit-aqua
  • python39Packages.sslyze
  • python39Packages.ufoprocessor
  • sourcehut.gitsrht
  • sourcehut.todosrht
58 packages built:
  • flexget
  • freecell-solver
  • noto-fonts-emoji
  • photon
  • python37Packages.Quandl (python37Packages.quandl)
  • python37Packages.afdko
  • python37Packages.booleanoperations
  • python37Packages.defcon
  • python37Packages.factory_boy
  • python37Packages.faker
  • python37Packages.flask-restx
  • python37Packages.fontmath
  • python37Packages.fontparts
  • python37Packages.fontpens
  • python37Packages.fonttools
  • python37Packages.minio
  • python37Packages.mutatormath
  • python37Packages.nototools
  • python37Packages.psautohint
  • python37Packages.pytest-factoryboy
  • python37Packages.pytest-randomly
  • python37Packages.random2
  • python37Packages.tld
  • python37Packages.ufoprocessor
  • python38Packages.Quandl (python38Packages.quandl)
  • python38Packages.afdko
  • python38Packages.booleanoperations
  • python38Packages.defcon
  • python38Packages.factory_boy
  • python38Packages.faker
  • python38Packages.flask-restx
  • python38Packages.fontmath
  • python38Packages.fontparts
  • python38Packages.fontpens
  • python38Packages.fonttools
  • python38Packages.minio
  • python38Packages.mutatormath
  • python38Packages.nototools
  • python38Packages.psautohint
  • python38Packages.pytest-factoryboy
  • python38Packages.pytest-randomly
  • python38Packages.random2
  • python38Packages.tld
  • python38Packages.ufoprocessor
  • python39Packages.factory_boy
  • python39Packages.faker
  • python39Packages.flask-restx
  • python39Packages.minio
  • python39Packages.pytest-factoryboy
  • python39Packages.pytest-randomly
  • python39Packages.random2
  • python39Packages.scrapy-fake-useragent
  • python39Packages.tld
  • rictydiminished-with-firacode
  • scfbuild
  • visidata
  • xits-math
  • xquartz

@veehaitch
Copy link
Member Author

Result of nixpkgs-review pr 105905 run on x86_64-darwin 1

The packages this PR relates to seem to build fine for me. I doubt the failing packages have anything to do with the changes this PR introduces.

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 105905 run on x86_64-linux 1

3 packages failed to build:
  • python37Packages.sslyze
  • sslyze (python38Packages.sslyze)
  • python39Packages.sslyze
10 packages built:
  • freecell-solver
  • gnome3.aisleriot
  • kdeApplications.kpat
  • pysolfc
  • python37Packages.nassl
  • python37Packages.random2
  • python38Packages.nassl
  • python38Packages.random2
  • python39Packages.nassl
  • python39Packages.random2

sslyze:

ERROR: Could not find a version that satisfies the requirement cryptography<3.3,>=2.6 (from sslyze)
ERROR: No matching distribution found for cryptography<3.3,>=2.6

@veehaitch
Copy link
Member Author

Result of nixpkgs-review pr 105905 run on x86_64-linux 1
3 packages failed to build:
10 packages built:

sslyze:

ERROR: Could not find a version that satisfies the requirement cryptography<3.3,>=2.6 (from sslyze)
ERROR: No matching distribution found for cryptography<3.3,>=2.6

Thanks, fixed!

@veehaitch
Copy link
Member Author

nix-shell -p nixpkgs-review --run "nixpkgs-review wip"

6 packages built:
python37Packages.nassl python37Packages.sslyze python38Packages.nassl sslyze python39Packages.nassl python39Packages.sslyze

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 105905 run on x86_64-darwin 1

7 packages failed to build and are new build failures:

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 105905 run on x86_64-linux 1

6 packages built:
  • python37Packages.nassl
  • python37Packages.sslyze
  • python38Packages.nassl
  • sslyze (python38Packages.sslyze)
  • python39Packages.nassl
  • python39Packages.sslyze

Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Result of nixpkgs-review pr 105905 run on x86_64-linux 1

6 packages built:
  • python37Packages.nassl
  • python37Packages.sslyze
  • python38Packages.nassl
  • sslyze (python38Packages.sslyze)
  • python39Packages.nassl
  • python39Packages.sslyze

@jonringer jonringer merged commit 980c4c3 into NixOS:master Jan 12, 2021
@veehaitch veehaitch deleted the ssylze-3.1.0 branch January 12, 2021 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants