Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lib/strings: fix typo in example #105906

Merged
merged 1 commit into from Dec 4, 2020
Merged

lib/strings: fix typo in example #105906

merged 1 commit into from Dec 4, 2020

Conversation

alunduil
Copy link
Contributor

@alunduil alunduil commented Dec 4, 2020

The example refers to a snake_case function name but Nix uses camelCase
function names. This ensures the example is correct for the given
function.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@alunduil
lib/strings: fix typo in example
4a5cb36 
The example refers to a snake_case function name but Nix uses camelCase
function names.  This ensures the example is correct for the given
function.
@SuperSandro2000 SuperSandro2000 merged commit a048b71 into NixOS:master Dec 4, 2020
@alunduil alunduil deleted the withFeatureAs branch December 5, 2020 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 approved these changes

@edolstra edolstra Awaiting requested review from edolstra

@infinisil infinisil Awaiting requested review from infinisil infinisil is a code owner

@nbp nbp Awaiting requested review from nbp

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@alunduil @SuperSandro2000