Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

octoprint: 1.4.2 -> 1.5.1 #105913

Merged
merged 5 commits into from Dec 7, 2020
Merged

octoprint: 1.4.2 -> 1.5.1 #105913

merged 5 commits into from Dec 7, 2020

Conversation

lovesegfault
Copy link
Member

Motivation for this change

I noticed it was out of date, the update required me to shave some yaks as well

  • python3Packages.sgmllib3k: init at 1.0.0
  • python3Packages.feedparser: 5.2.1 -> 6.0.2
  • octoprint: 1.4.2 -> 1.5.1
  • octoprint: sort propagatedBuildInputs
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@SuperSandro2000 SuperSandro2000 changed the title octoprint 1.5.1 octoprint: 1.4.2 -> 1.5.1 Dec 4, 2020
@SuperSandro2000
Copy link
Member

SuperSandro2000 commented Dec 5, 2020 •
edited

Result of nixpkgs-review pr 105913 run on x86_64-linux 1

7 packages failed to build:
  • appdaemon
  • quodlibet
  • quodlibet-full
  • quodlibet-without-gst-plugins
  • quodlibet-xine
  • quodlibet-xine-full
  • rss2email
23 packages built:
  • calibre (calibre-py3)
  • canto-curses
  • canto-daemon
  • flexget
  • foxtrotgps
  • gpodder
  • greg
  • kmymoney
  • octoprint
  • pubs
  • python37Packages.feedparser
  • python37Packages.sgmllib3k
  • python37Packages.weboob
  • python38Packages.feedparser
  • python38Packages.sgmllib3k
  • python38Packages.weboob
  • python39Packages.feedparser
  • python39Packages.sgmllib3k
  • python39Packages.weboob
  • sabnzbd
  • tartube
  • tribler
  • ytcc
  Processing ./appdaemon-4.0.5-py3-none-any.whl                                                                                                                                               Requirement already satisfied: azure-mgmt-compute in /nix/store/kbdfq67n5ps0al63f0g6msh54qvv6bfd-python3.8-azure-mgmt-compute-18.0.0/lib/python3.8/site-packages (from appdaemon==4.0.5) (18.0.0)                                                                                                                                                                                       Requirement already satisfied: azure-mgmt-storage in /nix/store/f34q1nkzxayajn51aigs5xg26awmwska-python3.8-azure-mgmt-storage-16.0.0/lib/python3.8/site-packages (from appdaemon==4.0.5) (16.0.0)                                                                                                                                                                                       ERROR: Could not find a version that satisfies the requirement feedparser==5.2.1 (from appdaemon==4.0.5) (from versions: none)                                                              ERROR: No matching distribution found for feedparser==5.2.1 (from appdaemon==4.0.5)                                                                                                       building of '/nix/store/075zmq7h2mmq3n9310j6qlia0va9brr8-rss2email-3.12.2.drv' timed out after 600 seconds of silence

Please disable the tests and add pythonImportsCheck.

rss2email.log
174:Ran 0 tests in 0.000s

canto-curses.log
213:Ran 0 tests in 0.000s

greg.log
133:Ran 0 tests in 0.000s

canto-daemon.log
202:Ran 0 tests in 0.000s

@lovesegfault
Copy link
Member Author

This currently fixes the broken feedparser in nixpkgs master. cc. @FRidh @jonringer

@orivej-nixos orivej-nixos merged commit 064b322 into NixOS:master Dec 7, 2020
@orivej-nixos
Copy link
Contributor

Thanks! I have fixed various issue that prevented building octoprint on the current master, and now it builds again.

@lovesegfault lovesegfault deleted the octoprint-1.5.1 branch December 7, 2020 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@orivej orivej orivej left review comments

@SuperSandro2000 SuperSandro2000 SuperSandro2000 left review comments

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

@gebner gebner Awaiting requested review from gebner

@WhittlesJr WhittlesJr Awaiting requested review from WhittlesJr

@abbradar abbradar Awaiting requested review from abbradar

@domenkozar domenkozar Awaiting requested review from domenkozar

Assignees
No one assigned
Labels
6.topic: python 8.has: clean-up 8.has: package (new) 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@lovesegfault @SuperSandro2000 @orivej-nixos @orivej