Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ink: init at 0.5.3 #105931

Merged
merged 3 commits into from Dec 7, 2020
Merged

ink: init at 0.5.3 #105931

merged 3 commits into from Dec 7, 2020

Conversation

samb96
Copy link
Contributor

@samb96 samb96 commented Dec 4, 2020

Motivation for this change

A command line tool for checking the ink level of a locally connected printer.

I also added the associated library: libinklevel: init at 0.9.3

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

SuperSandro2000
SuperSandro2000 requested changes Dec 5, 2020
View reviewed changes
pkgs/development/libraries/libinklevel/default.nix Outdated Show resolved Hide resolved
pkgs/tools/misc/ink/default.nix Outdated Show resolved Hide resolved
@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 105931 run on x86_64-linux 1

2 packages built:
  • ink
  • libinklevel

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 105931 run on x86_64-linux 1

2 packages built:
  • ink
  • libinklevel

@SuperSandro2000 SuperSandro2000 merged commit 920b3dd into NixOS:master Dec 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 Awaiting requested review from SuperSandro2000

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@samb96 @SuperSandro2000 @Janik-Haag