add InfluxDB2DataLogger (cli name influxdb2) to log into an InfluxDB 2.x #240
Conversation
Are |
yes, they replace I've marked all three parameters as mandatory. |
I think they should be positional arguments if they replace a positional argument |
|
Makes sense. Done. |
|
The help text should be written in the same style as for the other options. Other than that, are authentication changes the only difference between influxdb 1 and 2? |
Done. (I blame my co2 level for forgetting to replace the placeholder before opening the PR. brb opening a window.)
There is no more parameter |
|
Thanks! |
This adds a new logger named
influxdb2.At first I wanted to expand the existing
influxdblogger, but there are a few differences between 1.x and 2.x:dbparameterorgandbucketretention-policyon write, instead the retention period is configured statically on the bucketThe token could have been added as an optional parameter, but the discrepancy between the single positional parameter
dband the two parametersorg/bucketwould have been awkward.I've tested this against a local influxdb running in docker (
docker run --rm -it --name influxdb -p 8086:8086 quay.io/influxdb/influxdb:v2.0.2) and against the cloud version.The invocation to log it into the cloud would look like this:
Endpoint depends on the backend, for example
https://eu-central-1-1.aws.cloud2.influxdata.comorgcan either be the Organization name or id. It can be copied from the UI url.This is my first PR against glasgow, and I don't do much python, so any feedback is welcome.