Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rofimoji: unbreak #106636

Merged
merged 1 commit into from Dec 11, 2020
Merged

rofimoji: unbreak #106636

merged 1 commit into from Dec 11, 2020

Conversation

reedrw
Copy link
Contributor

@reedrw reedrw commented Dec 11, 2020

Motivation for this change

This package was broken by 40389df, but I fixed it by patching the setup.py

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

drewrisinger
drewrisinger suggested changes Dec 11, 2020
View reviewed changes
Copy link
Contributor

@drewrisinger drewrisinger left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Diff should use substituteInPlace vs patches = [...];
  • Commits LGTM
  • Haven't tested build yet.

pkgs/applications/misc/rofimoji/default.nix Outdated Show resolved Hide resolved
drewrisinger
drewrisinger approved these changes Dec 11, 2020
View reviewed changes
Copy link
Contributor

@drewrisinger drewrisinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Diff LgTM
  • Commits LGTM
  • Builds fine via nix-review
https://github.com/NixOS/nixpkgs/pull/106636
1 package built:
rofimoji

jonringer
jonringer approved these changes Dec 11, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Result of nixpkgs-review pr 106636 1

1 package built:
  • rofimoji

@jonringer jonringer merged commit c099efb into NixOS:master Dec 11, 2020
@reedrw reedrw deleted the unbreak-rofimoji branch December 12, 2020 02:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@drewrisinger drewrisinger drewrisinger approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@reedrw @jonringer @drewrisinger