New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[treewide]: drop some packages that have been broken for over a year #106625
Conversation
It was marked in commit 893ab31 by zimbatm on 2016-06-25 (commited on 2016-06-25)
It was marked in commit ad902fb by Joachim Fasting on 2017-03-30 (commited on 2017-03-30)
It was marked in commit 99e74e9 by Jörg Thalheim on 2017-03-06 (commited on 2017-03-06)
It was marked in commit d862700 by xeji on 2018-04-10 (commited on 2018-04-12)
It was marked in commit e416a39 by Daniel Schaefer on 2019-09-14 (commited on 2019-09-14)
It was marked in commit 3ddd199 by Vladimír Čunát on 2015-12-21 (commited on 2015-12-21)
It was marked in commit 5aa4b19 by Linus Heckemann on 2019-10-07 (commited on 2019-10-08)
It was marked in commit e047722 by Franz Pletz on 2017-08-27 (commited on 2017-08-28)
It was marked in commit c7ffe17 by Franz Pletz on 2017-07-31 (commited on 2019-07-29)
It was marked in commit 9aae605 by Yegor Timoshenko on 2017-09-28 (commited on 2017-09-28)
It was marked in commit 5aa4b19 by Linus Heckemann on 2019-10-07 (commited on 2019-10-08)
It was marked in commit de05176 by Piotr Bogdan on 2017-12-23 (commited on 2017-12-23)
It was marked in commit f63c179 by Bart Brouns on 2016-11-07 (commited on 2016-11-07)
It was marked in commit 5aa4b19 by Linus Heckemann on 2019-10-07 (commited on 2019-10-08)
It was marked in commit 96cf58a by xeji on 2018-04-10 (commited on 2018-04-12)
It was marked in commit 36fe554 by Peter Simons on 2019-10-30 (commited on 2019-10-30)
…for over one year
It was marked in commit 43a8ce0 by Kirill Boltaev on 2016-09-12 (commited on 2016-09-12)
It was marked in commit b5ad5c3 by Robin Gloster on 2017-03-30 (commited on 2017-03-30)
It was marked in commit f23c765 by Vincent Laporte on 2018-08-29 (commited on 2018-08-29)
It was marked in commit f70a896 by Robin Gloster on 2017-03-14 (commited on 2017-03-14)
It was marked in commit f6d4d59 by Bjørn Forsman on 2014-09-13 (commited on 2014-09-13)
It was marked in commit 5ee52f9 by xeji on 2018-04-10 (commited on 2018-04-12)
It was marked in commit 5aa4b19 by Linus Heckemann on 2019-10-07 (commited on 2019-10-08)
It was marked in commit 68c15ce by xeji on 2018-04-11 (commited on 2018-04-12)
…for over one year
It was marked in commit 5aa4b19 by Linus Heckemann on 2019-10-07 (commited on 2019-10-08)
It was marked in commit 19d1dae by Uli Baum on 2018-09-13 (commited on 2018-09-13) Also drop corresponding module.
It was marked in commit 5aa4b19 by Linus Heckemann on 2019-10-07 (commited on 2019-10-08)
It was marked in commit d7f3e5a by Robin Gloster on 2017-03-29 (commited on 2017-03-30)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I appreciate this. Since nixpkgs we have a low bar for adding packages, we also should have a low bar for removing packages that nobody cares to fixes.
This could be used for automatic remove aliases:
|
Before merging this, someone should maybe check if any of these packages haven open PRs that fix them, that just got stuck. I assume and hope that this is not the case, but it should probably be done anyways. Oh and I forgot to mention that this is actually a relatively conservative estimate/implementation. It only handles packages for which |
It may be hard to know that these packages once existed in nixpkgs, though. So someone wanting to (re-)add one of the these packages to nixpkgs might end up writing an expression from scratch when they could have started from the old broken expression. (In fact just now I was poking around to see if I could fix Maybe it would be good to write the names of these removed packages in a text file and store it somewhere in the repo, so that it would be found with a simple grep of the repository for the name of the software. |
In general, searching GitHub is always a good idea, because there might already be a ready but unmerged or WIP PR open. Which isn't to say we shouldn't keep a list of dropped packages around, but just something I've run into at least once before. Especially with niche software, finding a reviewer and merger can be hard. |
Ok, so I did the searches, here are my results: Someone already wanted to drop Somebody noticed that
Someone tried to bump The I hope I haven't missed anything. I have not done anything with these findings yet. Edit: I forgot about #54383, which tries to fix |
I noticed that there are a lot of entries in |
In fact i am stuck on this package as cmake is using FetchContent We can drop it |
Turns out, I don't care enough about this, after all. |
Is this still of interest to anyone? |
I am interested. Maybe @ajs124 could share the script that was used for this. |
@Mic92 Yes I think nixpkgs needs more scripts to remove stalled things to avoid bloat. It is easy to add stuff, so removing stuff should also be easy when unmaintained/broken |
(perhaps we should move conversation into a separate issue/RFC) I have a concern that it would make it harder to take advantage of previous packaging attempts. Perhaps a broken package only needs some tweaks to unbreak but removing it would make the past attempt harder to find. |
(perhaps we should move conversation into a separate issue/RFC)
I have a concern that it would make it harder to take advantage of previous packaging attempts. Perhaps a broken package only needs some tweaks to unbreak but removing it would make the past attempt harder to find.
Hm. Maybe it makes sense to create a separate nixpkgs-attic or something repository, with all the expressions that have been dropped?… But I am not going to write these scripts anytime soon.
|
I think there is an easy fix. We could add the commit where a package was removed in the message of |
Adding the alias will need to be a separate commit then from removing the expression. If you want to see if there is an older package you can use |
Perhaps we could put this in the documentation somewhere.
Agree. While Nixpkg's size is impressive, we do need to have some baseline quality and a 1-year timeout for broken packages seems reasonable to me. |
Well. if we would automate it this could be added as a feature. But we probably don't need to ask contributor to provide it otherwise. |
Motivation for this change
These have not been working for over a year, so why keep carrying them around?
If anyone ever needs them again, they can revert the respective commit.
cc @Mic92
These do not have entries in aliases.nix yet. If there is a consensus that they are needed, I can add them.
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)