Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libseccomp: make pythonsrc reproducible #106644

Merged
merged 1 commit into from Dec 15, 2020
Merged

libseccomp: make pythonsrc reproducible #106644

merged 1 commit into from Dec 15, 2020

Conversation

raboof
Copy link
Member

@raboof raboof commented Dec 11, 2020

Motivation for this change

makes the pythonsrc reproducible by making the file date and
ordering static.

A more general solution to this problem has been proposed in
#106643

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@raboof
libseccomp: make pythonsrc reproducible
0fbe559 
makes the pythonsrc reproducible by making the file date and
ordering static.

A more general solution to this problem has been proposed in
NixOS#106643
@ofborg ofborg bot requested a review from thoughtpolice December 11, 2020 09:42
@raboof raboof changed the base branch from master to staging December 11, 2020 09:48
thoughtpolice
thoughtpolice approved these changes Dec 15, 2020
View reviewed changes
Copy link
Member

@thoughtpolice thoughtpolice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh dear, thanks for the quick fix!

@thoughtpolice thoughtpolice merged commit f808840 into NixOS:staging Dec 15, 2020
@prusnak prusnak mentioned this pull request Dec 20, 2020
Closed
10 tasks
@KamilaBorowska KamilaBorowska mentioned this pull request Dec 22, 2020
Closed
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thoughtpolice thoughtpolice thoughtpolice approved these changes

@FRidh FRidh FRidh approved these changes

Assignees
No one assigned
Labels
6.topic: reproducible builds 10.rebuild-darwin: 11-100 10.rebuild-linux: 501+ 10.rebuild-linux: 5001+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@raboof @thoughtpolice @FRidh