Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.hass-nabucasa: 0.37.2 -> 0.39.0 #106623

Merged
merged 1 commit into from Dec 14, 2020
Merged

pythonPackages.hass-nabucasa: 0.37.2 -> 0.39.0 #106623

merged 1 commit into from Dec 14, 2020

Conversation

marsam
Copy link
Contributor

@marsam marsam commented Dec 11, 2020

Motivation for this change

Fix #106497
cc: @wmertens

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from Scriptkiddi December 11, 2020 03:07
@mweinelt
Copy link
Member

I've also prepared this change in time for the 1.0 release on the 13th, but please don't merge it before we upgraded home-assistant.

@mweinelt mweinelt added the 2.status: wait-for-upstream Waiting for upstream fix (or their other action). label Dec 11, 2020
@mweinelt mweinelt self-assigned this Dec 11, 2020
@mweinelt mweinelt mentioned this pull request Dec 13, 2020
Merged
10 tasks
@mweinelt
Copy link
Member

Result of nixpkgs-review pr 106623 run on x86_64-linux 1

4 packages built:
  • home-assistant
  • python37Packages.hass-nabucasa
  • python38Packages.hass-nabucasa
  • python39Packages.hass-nabucasa

@mweinelt mweinelt merged commit 8e4788b into NixOS:master Dec 14, 2020
@mweinelt mweinelt removed the 2.status: wait-for-upstream Waiting for upstream fix (or their other action). label Dec 14, 2020
@marsam marsam deleted the update-hass-nabucasa branch May 31, 2023 05:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mweinelt mweinelt mweinelt approved these changes

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

@Scriptkiddi Scriptkiddi Awaiting requested review from Scriptkiddi

Assignees

@mweinelt mweinelt

Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

hass-nabucasa doesn't build
2 participants
@marsam @mweinelt