/marvin opt-in
/status needs_reviewer

Hi! I'm an experimental bot. My goal is to guide this PR through its stages, hopefully ending with a merge. You can read up on the usage here.

@Atemu how do I test this? Just building and running from result/bin/anki doesn't seem to do much:

vika@primrose ~ $ result-anki-bin/bin/anki
  File "runanki.py", line 4, in <module>
  File "aqt/__init__.py", line 399, in run
  File "aqt/__init__.py", line 445, in _run
  File "aqt/profiles.py", line 92, in setupMeta
  File "aqt/profiles.py", line 456, in _loadMeta
resetting corrupt _global
Qt warning: Failed to load client buffer integration: "wayland-egl"
Qt warning: Available client buffer integrations: ()
Qt warning: No shell integration named "xdg-shell" found
Qt warning: No shell integration named "xdg-shell-v6" found
Qt warning: No shell integration named "wl-shell" found
Qt warning: No shell integration named "ivi-shell" found
Qt warning: Loading shell integration failed.
Qt warning: Attempted to load the following shells ("xdg-shell", "xdg-shell-v6", "wl-shell", "ivi-shell")

Are you on wayland? Any QT environment variables set?

I only tested this on Xorg and I don't think it'd work anywhere else.

Yes, I am on Wayland, as Xorg doesn't work on my laptop properly. What would be the quickest way to launch, say, a window with Openbox inside to test an Xorg-only app?

$ env | grep -ie wayland -e qt
QTWEBKIT_PLUGIN_PATH=/home/vika/.local/share/flatpak/exports/lib/mozilla/plugins/:/var/lib/flatpak/exports/lib/mozilla/plugins/:/home/vika/.nix-profile/lib/mozilla/plugins/:/etc/profiles/per-user/vika/lib/mozilla/plugins/:/nix/var/nix/profiles/default/lib/mozilla/plugins/:/run/current-system/sw/lib/mozilla/plugins/
WAYLAND_DISPLAY=wayland-0
QT_QPA_PLATFORMTHEME=gtk2
BEMENU_BACKEND=wayland
SDL_VIDEODRIVER=wayland
XDG_SESSION_TYPE=wayland
QT_PLUGIN_PATH=/home/vika/.local/share/flatpak/exports/lib/qt4/plugins:/home/vika/.local/share/flatpak/exports/lib/kde4/plugins:/var/lib/flatpak/exports/lib/qt4/plugins:/var/lib/flatpak/exports/lib/kde4/plugins:/home/vika/.nix-profile/lib/qt4/plugins:/home/vika/.nix-profile/lib/kde4/plugins:/etc/profiles/per-user/vika/lib/qt4/plugins:/etc/profiles/per-user/vika/lib/kde4/plugins:/nix/var/nix/profiles/default/lib/qt4/plugins:/nix/var/nix/profiles/default/lib/kde4/plugins:/run/current-system/sw/lib/qt4/plugins:/run/current-system/sw/lib/kde4/plugins
QT_WAYLAND_DISABLE_WINDOWDECORATION=1
QT_QPA_PLATFORM=wayland
MOZ_ENABLE_WAYLAND=1

It might be worth trying to run it in XWayland. env -i ./result/bin/anki should clear any env variable signaling QT to use Wayland natively and it'd fall back to X11.

Otherwise, nixos-rebuild build-vming your config with but with Xorg would probably be pretty simple and easy.

I cleared my environment and after adding LANG and DISPLAY I can confirm the application launches. With the exception of a nitpick mentioned in my review above, this looks ready to merge.

Oh, wait, I accidentally broke the bot. /status awaiting_changes

/status needs_merger

If it works in XWayland and there's an easy way to force that via a wrapper, I could at least do that.

Since this already tripped up two people, I think we should add the wrapper. Clearing the environment seemed to work, do you know which variables were at fault? If not, @kisik21 could you try to find out?

@Profpatsch I tend to agree with @Atemu that we don't need to explicitly migrate people. They can opt-in to anki-bin, and then they will notice once the package is no longer available. Having to replace anki-bin with anki again seems reasonable to me. At least that way they'll be aware of it too. What do you think?

I'll get on that when I get my AMDGPU on Wednesday and can actually use Wayland properly. Can't wait to finally be free of this blobby Nvidia crap.

Thanks for digging into this @kisik21 :) No hurry, I'll just change the status so that marvin won't nag us.

/status awaiting_changes