python36Packages.black: fix broken dependency #106622
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Result of |
In PR NixOS#96456, black was upgraded from 19.10b0 to 20.8b1. This new version of black depends on the dataclasses module, but that was only introduced into the standard library in Python 3.7; earlier versions of Python require the backport package of the same name. This commit addresses the missing dependency.
kini
force-pushed
the
kkini/python36-black-fix
branch
from
4d6e7d8
to
e68887e
Compare
drewrisinger
approved these changes
Dec 11, 2020
There was a problem hiding this comment.
- Diff LGTM
- Commits LGTM
- Builds cleanly locally:
nix-build -A python36Packages.black
...
========== 143 passed, 4 deselected, 3 xfailed, 13 warnings in 37.63s ==========
Finished executing pytestCheckPhase
pytestcachePhase
/nix/store/mvdcj0vrj1xp89ndqyjyzd05zc5brd0g-python3.6-black-20.8b1
[nix-shell:~/.cache/nixpkgs-review/pr-106622/nixpkgs]$
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In PR #96456, black was upgraded from 19.10b0 to 20.8b1. On Python 3.6 only,
this new version of black depends on the dataclasses package, but that wasn't
specified in the buildInputs, so this commit fixes that.
Motivation for this change
python36Packages.blackdoesn't build.Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)