Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

filesystems: add syntax to /etc/fstab header #105786

Merged
merged 1 commit into from Aug 26, 2021
Merged

filesystems: add syntax to /etc/fstab header #105786

merged 1 commit into from Aug 26, 2021

Conversation

teto
Copy link
Member

@teto teto commented Dec 3, 2020

Motivation for this change

ubuntu displays it and it helps in case you forgot the syntax and dont want to consult the man.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@teto
filesystems: add syntax to /etc/fstab header
3562533 
ubuntu displays it and it helps in case you forgot the syntax and dont want to consult the man
@ajs124
Copy link
Member

ajs124 commented Dec 3, 2020

Why do you need to know the syntax? This really shouldn't be edited manually, in the first place.

I've been wondering for a while why NixOS even generates a /etc/fstab instead of systemd mount units.

@teto
Copy link
Member Author

teto commented Dec 3, 2020

it doesn't have to be edited (though when something goes wrong, like you have two disks with the same UUID, it can be good to bypass nix), but just to inspect the system. I dunno about systemd mount units but if we do that, we should put some doc in the fstab.
I wonder if this PR could break some tests.

@stale
Copy link

stale bot commented Jun 2, 2021

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jun 2, 2021
davidak
davidak approved these changes Aug 26, 2021
View reviewed changes
Copy link
Member

@davidak davidak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks good

hopefully not breaking anything

@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Aug 26, 2021
@davidak davidak merged commit a023b22 into NixOS:master Aug 26, 2021
@teto teto deleted the fstab branch September 5, 2021 22:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidak davidak davidak approved these changes

@SuperSandro2000 SuperSandro2000 SuperSandro2000 approved these changes

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@teto @ajs124 @davidak @SuperSandro2000