Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

unbound: 1.12.0 -> 1.13.0 #105782

Merged
merged 1 commit into from Dec 8, 2020
Merged

unbound: 1.12.0 -> 1.13.0 #105782

merged 1 commit into from Dec 8, 2020

Conversation

mweinelt
Copy link
Member

@mweinelt mweinelt commented Dec 3, 2020

https://lists.nlnetlabs.nl/pipermail/unbound-users/2020-December/007102.html

Fixes: CVE-2020-28935

Motivation for this change

New upstream release.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested review from globin, fpletz and ehmry December 3, 2020 11:01
@mweinelt mweinelt added this to WIP in Staging via automation Dec 3, 2020
@RaghavSood RaghavSood added the 9.needs: port to stable A PR needs a backport to the stable release. label Dec 3, 2020
@mweinelt
Copy link
Member Author

mweinelt commented Dec 3, 2020 •
edited

I don't think we are affected by CVE-2020-28935, so I don't think this warrants a backport to stable. Please speak up if you disagree.

@mweinelt mweinelt removed the 9.needs: port to stable A PR needs a backport to the stable release. label Dec 3, 2020
@pmeiyu pmeiyu mentioned this pull request Dec 8, 2020
Merged
10 tasks
@FRidh FRidh merged commit e8959c4 into NixOS:staging Dec 8, 2020
Staging automation moved this from WIP to Done Dec 8, 2020
@mweinelt mweinelt deleted the unbound branch December 8, 2020 05:59
@dotlambda
Copy link
Member

This should have been backported: #110673

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ehmry ehmry ehmry approved these changes

@globin globin Awaiting requested review from globin

@fpletz fpletz Awaiting requested review from fpletz

Assignees
No one assigned
Labels
1.severity: security 10.rebuild-darwin: 501+ 10.rebuild-darwin: 1001-2500 10.rebuild-linux: 501+ 10.rebuild-linux: 5001+
Projects
Staging
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@mweinelt @dotlambda @ehmry @RaghavSood @FRidh