Properly test the early cutoff for CA derivations #4308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the build closure contains some CA derivations, then we can't know ahead-of-time that we won't build anything as early-cutoff might come-in at a laster stage
Build things with a different seed each time to make sure that it works despite the different drvs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current ca test suite doesn't really test early cutoff as it should because the tests that are supposed to do it don't change the
seedargument, meaning that they build twice the exact same derivation rather than two derivations that resolve to the same thing. Fix that to make the test actually useful.(I'm not sure what happened to this testsuite, but between this and #4282 it seems to have been mostly useless so far…).
Also removes the early check for
-j0in the build loop as it's invalid with CA derivations (and would in particular make this test quite more painful to write)