Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

steam/fhsenv: Add LD_LIBRARY_PATH (and hence OpenGL driver library path) to output of --print-steam-runtime-library-paths #106843

Merged
merged 1 commit into from Dec 16, 2020
Merged

steam/fhsenv: Add LD_LIBRARY_PATH (and hence OpenGL driver library path) to output of --print-steam-runtime-library-paths #106843

merged 1 commit into from Dec 16, 2020

Conversation

jbalme
Copy link
Contributor

@jbalme jbalme commented Dec 13, 2020

steam/fhsenv: Add LD_LIBRARY_PATH (and hence OpenGL driver library path) to output of --print-steam-runtime-library-paths

Motivation for this change

Fixes #106503

Needed because Steam now replaces LD_LIBRARY_PATH with the runtime's path, instead of prepending.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@jbalme
steam/fhsenv: Add LD_LIBRARY_PATH (and hence OpenGL driver library pa…
56855c5 
…th) to output of --print-steam-runtime-library-paths
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/i-cannot-run-l4d2-nor-portal/9982/22

fabianhjr
fabianhjr approved these changes Dec 16, 2020
View reviewed changes
Copy link
Member

@fabianhjr fabianhjr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mohe2015
mohe2015 approved these changes Dec 16, 2020
View reviewed changes
Copy link
Contributor

@mohe2015 mohe2015 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fixed starting a game for me

@fabianhjr
Copy link
Member

/cc @jonringer seems like no maintainers were tagged for review and this commit helped me with a steam issue.

jonringer
jonringer approved these changes Dec 16, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Result of nixpkgs-review pr 106843 run on x86_64-linux 1

5 packages built:
  • kodiPlugins.steam-launcher
  • lutris
  • steam
  • steam-run
  • steamcmd

@jonringer jonringer merged commit 0127c29 into NixOS:master Dec 16, 2020
@1000101
Copy link
Member

1000101 commented Dec 19, 2020

Shouldn't we also backport this to stable?

@fabianhjr
Copy link
Member

fabianhjr commented Dec 19, 2020 •
edited

Yes, that would be ideal. Good experience overall and fixed the Valve games on linux issue #106503 (tried portal 2) also mentioned on https://discourse.nixos.org/t/i-cannot-run-l4d2-nor-portal/9982

@1000101 1000101 mentioned this pull request Dec 20, 2020
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabianhjr fabianhjr fabianhjr approved these changes

@jonringer jonringer jonringer approved these changes

@mohe2015 mohe2015 mohe2015 approved these changes

Assignees
No one assigned
Labels
6.topic: steam 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Steam games fail to start with "Couldn't find matching GLX visual"
7 participants
@jbalme @nixos-discourse @fabianhjr @1000101 @jonringer @mohe2015 @Janik-Haag