Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

haskellPackages.brotli{,brotli-streams}: unbreak #106667

Merged
merged 1 commit into from Dec 12, 2020
Merged

haskellPackages.brotli{,brotli-streams}: unbreak #106667

merged 1 commit into from Dec 12, 2020

Conversation

poscat0x04
Copy link
Contributor

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@cdepillabout
Copy link
Member

Looks good, these both compile for me. Thanks

@cdepillabout cdepillabout merged commit 0429ae1 into NixOS:haskell-updates Dec 12, 2020
@poscat0x04 poscat0x04 deleted the unbreak-brotli branch December 12, 2020 02:58
@poscat0x04
Copy link
Contributor Author

would be appreciated if we could regenerate hackage-packages.nix

@cdepillabout
Copy link
Member

would be appreciated if we could regenerate hackage-packages.nix

That happens once a day automatically on the haskell-updates branch.

@poscat0x04
Copy link
Contributor Author

ohh, I guess I was too impatient :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cdepillabout cdepillabout Awaiting requested review from cdepillabout

Assignees
No one assigned
Labels
6.topic: haskell 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@poscat0x04 @cdepillabout