Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python36Packages.traitlets, pythonPackages.traitlets: 5.0.5 -> 4.3.3 (downgrade on Python 3.6 and older) #106653

Merged
merged 1 commit into from Dec 11, 2020
Merged

python36Packages.traitlets, pythonPackages.traitlets: 5.0.5 -> 4.3.3 (downgrade on Python 3.6 and older) #106653

merged 1 commit into from Dec 11, 2020

Conversation

kini
Copy link
Member

@kini kini commented Dec 11, 2020 •
edited

Version 5.x of traitlets requires Python 3.7, so it doesn't build on Python
3.6. This commit downgrades traitlets to 4.3.3 on Python versions older than
3.7 so that it can still be used.

Motivation for this change

IPython is broken on Python 3.6.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@kini
Copy link
Member Author

kini commented Dec 11, 2020

This sort of undoes 55324b5, so I'll ping @orivej.

orivej
orivej approved these changes Dec 11, 2020
View reviewed changes
Copy link
Contributor

@orivej orivej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine, thank you!

FRidh
FRidh reviewed Dec 11, 2020
View reviewed changes
Copy link
Member

@FRidh FRidh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other then the maintainer field fine by me

pkgs/development/python-modules/traitlets/4.nix Outdated Show resolved Hide resolved
@kini
python36Packages.traitlets, pythonPackages.traitlets: 5.0.5 -> 4.3.3
b1d5684 
Version 5.x of traitlets requires Python 3.7, so it doesn't build on Python
3.6.  This commit downgrades traitlets to 4.3.3 on Python versions older than
3.7 so that it can still be used.
@kini kini force-pushed the backport-traitlets-downgrade branch from 3c7dda3 to b1d5684 Compare December 11, 2020 12:00
jonringer
jonringer approved these changes Dec 11, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jonringer jonringer merged commit ce5b550 into NixOS:master Dec 11, 2020
@kini kini deleted the backport-traitlets-downgrade branch December 13, 2020 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh FRidh left review comments

@orivej orivej orivej approved these changes

@jonringer jonringer jonringer approved these changes

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@kini @orivej @FRidh @jonringer