Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

applet.video.hub75_output: implement basic HUB75 test pattern generator #246

Merged
merged 1 commit into from Aug 1, 2023
Merged

applet.video.hub75_output: implement basic HUB75 test pattern generator #246

merged 1 commit into from Aug 1, 2023

Conversation

attie
Copy link
Member

@attie attie commented Dec 11, 2020

This patch implements a basic test pattern generator for HUB75 LED Matrix panels, much like the VGA output applet.

The output is only 3-bit / 8-color, with no attempt at producing more colors or brightness control.

Panels of various shapes and sizes are supported, I've developed with a 64x64 1/32 scan panel, and have also tested with a second connected to produce a resolution of 128x64.

@attie attie force-pushed the hub75 branch 2 times, most recently from 0785017 to 45e8fb4 Compare December 11, 2020 16:36
@attie attie mentioned this pull request Dec 29, 2020
Merged
@attie
Copy link
Member Author

attie commented Dec 29, 2020

I've copied the VGA approach here, with the pixel generator hard-coded.

The usage here is slightly different:

  • As the display is drawn two lines at a time, I've moved it into a function, rather than duplicate the code
  • Because the HUB75 panels can vary in resolution significantly, I've included a --pattern-rate argument that will scale the generated pattern

Base automatically changed from master to main February 27, 2021 09:59
whitequark
whitequark reviewed Jul 24, 2023
View reviewed changes
Copy link
Member

@whitequark whitequark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but:

  • please update for the applet to build,
  • please add dual newlines before/after any class or function at the toplevel,
  • please add yourself as a code owner for it.

@attie attie force-pushed the hub75 branch 2 times, most recently from ce2916d to 95af8aa Compare July 31, 2023 19:22
@attie
Copy link
Member Author

attie commented Jul 31, 2023 •
edited

Should be good to go - merge after #357

@whitequark
Copy link
Member

Can you rebase this?

@attie
Copy link
Member Author

attie commented Aug 1, 2023

Done

whitequark
whitequark approved these changes Aug 1, 2023
View reviewed changes
Copy link
Member

@whitequark whitequark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@attie attie enabled auto-merge August 1, 2023 16:39
@attie attie mentioned this pull request Aug 1, 2023
Merged
@attie attie added this pull request to the merge queue Aug 1, 2023
Merged via the queue into GlasgowEmbedded:main with commit 1daefb3 Aug 1, 2023
8 of 9 checks passed
@attie attie deleted the hub75 branch August 1, 2023 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@whitequark whitequark whitequark approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@attie @whitequark