Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

linuxPackages.rtl8821ce: 5.5.2_34066.20200325 -> unstable-2020-12-16 #106661

Merged
merged 1 commit into from Feb 4, 2021
Merged

linuxPackages.rtl8821ce: 5.5.2_34066.20200325 -> unstable-2020-12-16 #106661

merged 1 commit into from Feb 4, 2021

Conversation

IvarWithoutBones
Copy link
Member

@IvarWithoutBones IvarWithoutBones commented Dec 11, 2020 •
edited

Motivation for this change

I noticed that on kernel 5.9.12 the wifi driver seems to sometimes not work correctly, which causes the system to not boot into my graphical session. Based on my minimal testing, this seems to fix that.

Tested with linuxPackages_latest.

Versioning was (as far as i can tell) based on this. This does not increment on every commit, while we weren't fetching a specific version, but instead a git commit. I've switch to the unstable-${date} convention.

This fixes: #107829

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nixpkgs-review pr 106661
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from hhm0 December 11, 2020 14:41
@IvarWithoutBones IvarWithoutBones changed the title linuxPackages.rtl8821ce: 5.5.2_34066.20200325 -> unstable-2020-11-15 linuxPackages.rtl8821ce: 5.5.2_34066.20200325 -> unstable-2020-12-16 Jan 5, 2021
@ofborg ofborg bot requested a review from samuelgrf January 5, 2021 01:55
@IvarWithoutBones IvarWithoutBones mentioned this pull request Jan 5, 2021
Closed
@IvarWithoutBones
Copy link
Member Author

@SuperSandro2000 rebased, should not have any merge conflicts anymore :)

samuelgrf
samuelgrf approved these changes Feb 3, 2021
View reviewed changes
Copy link
Member

@samuelgrf samuelgrf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can confirm this works and can be merged @SuperSandro2000 .
I tested rebuilding with linuxPackages_latest and connecting to wifi after reboot.
Sorry for taking so long to review this btw.

@samuelgrf samuelgrf added the 9.needs: port to stable A PR needs a backport to the stable release. label Feb 3, 2021
@SuperSandro2000 SuperSandro2000 merged commit 2fe06d9 into NixOS:master Feb 4, 2021
@IvarWithoutBones IvarWithoutBones deleted the update-rtl8821ce branch February 4, 2021 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samuelgrf samuelgrf samuelgrf approved these changes

@hhm0 hhm0 Awaiting requested review from hhm0

Assignees
No one assigned
Labels
9.needs: port to stable A PR needs a backport to the stable release. 10.rebuild-darwin: 0 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

linuxPackages_latest.rtl8821ce fails to compile
3 participants
@IvarWithoutBones @samuelgrf @SuperSandro2000